Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): Create directory before download #5

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix(s3): Create directory before download #5

merged 1 commit into from
Jul 21, 2021

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jul 9, 2021 •
edited
Loading

Create the required directories before downloading files from S3.
Also add new volume type GP3.

Closes #4

@GMishx
fix(s3): Create directory before download
90839fb 
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
ag4ums
ag4ums approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@ag4ums ag4ums merged commit cb17d66 into master Jul 21, 2021
@ag4ums ag4ums deleted the fix/s3/create-directory branch July 21, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag4ums ag4ums ag4ums approved these changes

Assignees

@ag4ums ag4ums

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 download fails if restore key is a folder
2 participants
@GMishx @ag4ums