Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix depth subpath bug #16

Merged
merged 3 commits into from
Feb 17, 2020
Merged

fix depth subpath bug #16

merged 3 commits into from
Feb 17, 2020

Conversation

lzecca78
Copy link
Contributor

Due to a bug discovered during the provisioning of module velero with @simonemex and @lnovara that has. a subdir of multiple path, here it is the patch for this bug. Now the function will handle whatever hierarchy level of subdir will exist in the repo

Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lzecca78 ! I'm seeing a lot of format changes in the diff (changed from 2 to 4 spaces identation), I think we have an style guideline but I'm not 100% sure, could you please confirm @angelbarrera92 ?

@lzecca78
Copy link
Contributor Author

hi @ralgozino , you are right, is my vim configuration that is set in that way. Is pretty the usual configuration, but if is something that have to adapted to a standard, just let me know and i will change it 👍

@angelbarrera92
Copy link
Contributor

Thanks @lzecca78 ! I'm seeing a lot of format changes in the diff (changed from 2 to 4 spaces identation), I think w

I was working on it but there is not ready yet. So feel free to continue the PR

@lzecca78
Copy link
Contributor Author

Anyway I made a search and the standard in yaml Is 2 spaces so I changed my vim setup to match this standard.

@lzecca78 lzecca78 added the bug Something isn't working label Feb 16, 2020
@angelbarrera92 angelbarrera92 self-assigned this Feb 17, 2020
@angelbarrera92
Copy link
Contributor

LGTM! Waiting for one more feedback, @ralgozino or @phisco

Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@angelbarrera92 angelbarrera92 merged commit 8c9d635 into master Feb 17, 2020
@angelbarrera92 angelbarrera92 deleted the fix-url-multipath branch February 17, 2020 16:00
Al-Pragliola pushed a commit that referenced this pull request Dec 14, 2022
* fix multi subpath bug
* moved repo in right map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants