-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix depth subpath bug #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lzecca78 ! I'm seeing a lot of format changes in the diff (changed from 2 to 4 spaces identation), I think we have an style guideline but I'm not 100% sure, could you please confirm @angelbarrera92 ?
hi @ralgozino , you are right, is my vim configuration that is set in that way. Is pretty the usual configuration, but if is something that have to adapted to a standard, just let me know and i will change it 👍 |
I was working on it but there is not ready yet. So feel free to continue the PR |
Anyway I made a search and the standard in yaml Is 2 spaces so I changed my vim setup to match this standard. |
LGTM! Waiting for one more feedback, @ralgozino or @phisco |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* fix multi subpath bug * moved repo in right map
Due to a bug discovered during the provisioning of module velero with @simonemex and @lnovara that has. a subdir of multiple path, here it is the patch for this bug. Now the function will handle whatever hierarchy level of subdir will exist in the repo