Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert importation framework "successful update" info popup into notification Description #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manishvishnoi2
Copy link

Fixes 0000843.

@sherzodmuratov
Copy link
Contributor

Weren't able to apply/run this patch yet. But, it looks good to me. I think build failed because of other problem.

@manishvishnoi2
Copy link
Author

hello @sherzodmuratov What problem is occuring.Is it because of travis CI.Are you able to check/run other two of my PR.

@ghost
Copy link

ghost commented Mar 15, 2016

@sherzodmuratov is right, travis is considering the build as broken but it's not a problem in @manishvishnoi2's code, it's a problem on the sigmah-dev master branch. We are looking forward to fix this issue before looking at the pull-requests.

@manishvishnoi2
Copy link
Author

@numero-six ok.

@ghost
Copy link

ghost commented Mar 22, 2016

Well, Manish's code is straightforward. It seems OK to me, @osarrat can you checkout the manish branch and check that this is OK functionally?

You can use git instructions, see "command-line instructions" below, "Step 1: From your project repository, check out a new branch and test the changes.".

@ghost ghost assigned osarrat Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants