[pre-commit.ci] pre-commit autoupdate #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
8aecf78
to
9a93737
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
4c0e567
to
9365a02
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
6f75cb8
to
4d74aca
Compare
|
@sigmavirus24 any chance we can get this PR merged (once that last import issue is addressed)? When I run |
|
@jmeridth why would I merge something that breaks CI? I suspect I need to move to isort from the reorder python imports despite how fast the latter is but I don't have the time to do that |
😄 wasn't suggesting merging a breaking change. Gotcha re: isort and time. Will see what I can whip up for review. |
|
Sorry missed the parenthetical 🤦 I need to stop looking at notifications on my phone before I have coffee |
|
I do it all the time. All good. I'm brewing coffee as I type this. 😄 Thank you for the response, nonetheless. Excited to help. |
updates: - [github.com/psf/black: 23.12.1 → 24.3.0](psf/black@23.12.1...24.3.0) - [github.com/asottile/pyupgrade: v3.15.0 → v3.15.1](asottile/pyupgrade@v3.15.0...v3.15.1) - [github.com/pre-commit/mirrors-mypy: v1.8.0 → v1.9.0](pre-commit/mirrors-mypy@v1.8.0...v1.9.0)
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
8c1791c
to
c36217e
Compare
for more information, see https://pre-commit.ci
jmeridth
added a commit
to jmeridth/github3.py
that referenced
this pull request
Mar 21, 2024
- [x] keep it simple with just `--profile black` argument This is a premptive strike on sigmavirus24#1172 fix Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
added a commit
to jmeridth/github3.py
that referenced
this pull request
Mar 21, 2024
- [x] keep it simple with just `--profile black` argument - [x] update pull_request_template when asking for python-dateutil version - some engineers don't know to prefix `dateutil` with `python-` This is a premptive strike on sigmavirus24#1172 fix Signed-off-by: jmeridth <jmeridth@gmail.com>
2 tasks
sigmavirus24
added a commit
that referenced
this pull request
Mar 21, 2024
* chore: switch to isort from reorder python imports - [x] keep it simple with just `--profile black` argument - [x] update pull_request_template when asking for python-dateutil version - some engineers don't know to prefix `dateutil` with `python-` This is a premptive strike on #1172 fix Signed-off-by: jmeridth <jmeridth@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: add line-length to isort to match black re-run black, hopefully get us to a non-conflict Signed-off-by: jmeridth <jmeridth@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Use isort config to reduce churn --------- Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
|
@sigmavirus24 I did not do the upgrades. Only the isort move in #1173. I'm used to dependabot, so do we reopen and rebase or will |
jmeridth
added a commit
to jmeridth/github3.py
that referenced
this pull request
Mar 21, 2024
Was originally in sigmavirus24#1172 Also: - [x] remove safe option from pyproject black config - it is the default, so no need to state, stop config error notification - `fast` is the non-default option and works when added to config without error ([docs](https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#fast-safe)) - [x] add venv to excluding directories (most devs set their virtualenv to venv or .venv) Signed-off-by: jmeridth <jmeridth@gmail.com>
sigmavirus24
pushed a commit
that referenced
this pull request
Mar 21, 2024
* chore: hande upgrades Was originally in #1172 Also: - [x] remove safe option from pyproject black config - it is the default, so no need to state, stop config error notification - `fast` is the non-default option and works when added to config without error ([docs](https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#fast-safe)) - [x] add venv to excluding directories (most devs set their virtualenv to venv or .venv) Signed-off-by: jmeridth <jmeridth@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: