Fix Hot Reload of Development API for Windows OS

if the stdio is not set for child_process.fork, the windows fails without any error it has to be 'ignore' or the option silent: true has to be set. see nodejs/node#5146 see https://nodejs.org/api/child_process.html#child_processforkmodulepath-args-options see https://nodejs.org/api/child_process.html#optionsdetached
signageos · Mar 31, 2023 · 7f17004 · 7f17004
1 parent 0d5c035
commit 7f17004
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [Unreleased]
 ### Fixed
 - Development API - Reload devices when no one has connected yet
+- Development API - Hot Reload works correctly even on Windows systems
 
 ## [1.19.0] - 2023-03-29
 ### Added

diff --git a/src/Development/Applet/Serve/AppletServeManagement.ts b/src/Development/Applet/Serve/AppletServeManagement.ts
@@ -305,6 +305,7 @@ export class AppletServeManagement {
 		const serverPath = path.join(__dirname, 'AppletServerProcess');
 		const serverProcess = child_process.fork(serverPath, [appletUid, appletVersion, port.toString(), publicUrl], {
 			detached: true,
+			stdio: 'ignore',
 			execArgv: process.env.SOS_DEVELOPMENT_APPLET_SERVE_EXEC_ARGV?.split(' '),
 		});
 		const message = await new Promise((resolve, reject) => {