Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show message count next to contact name #1198

Closed
McLoo opened this issue Mar 18, 2014 · 26 comments
Closed

show message count next to contact name #1198

McLoo opened this issue Mar 18, 2014 · 26 comments
Labels

Comments

@McLoo
Copy link
Contributor

McLoo commented Mar 18, 2014

The stock rom shows the number of messages per thread (user/group).
This is a nice feature and should easily be integrated as the message count is passed to a variable in ConversationListItem.java already.

here my simple example:
count

not the nice light gray smaller number like the stock sms app...

Another wessenger shows the number of unread messages instead which also is a fine feature

@hunleyd
Copy link

hunleyd commented Mar 19, 2014

+1

@McLoo
Copy link
Contributor Author

McLoo commented Mar 20, 2014

Funny, everthing is already there. With six lines of code it looks realy nice.
Wonder if there was a specific reason to prepare this but not implement...

msgcount

like the stock app only counts > 1 are shown

shall i pull request this?

@lablans
Copy link

lablans commented Mar 20, 2014

Instead of the total count of messages, wouldn't we rather want to see the count of unread messages (#991)?

@leomayer
Copy link

Just for the sake of completeness:

  1. Wouldn't it be good to have something like unread/total e.g. 3/20 would indicate I haven't read three messages out of a total of 20
  2. Does the unread counter really makes sense? I mean, wouldn't it be enough, when I just see, the contact is bold highlighted and I perceive this as 'some messages are not read yet'?

If 1) is easily to do, then please go for it. But I wouldn't miss the unread counter THAT much ;)

@aprescott
Copy link

I don't think an unread counter is all that useful. If I know that there's at least one unread message, do I gain anything from knowing it's 5 versus 10? They might have been sent out over 6 hours or spread out over 6 minutes, but in any situation I'm going to have to go in and read the unread message(s). The UI simplicity of having a single counter probably beats having information that is largely not that useful.

@hunleyd
Copy link

hunleyd commented Mar 20, 2014

"I don't think an unread counter is all that useful. " I don't know. My social circle is pretty good about not spamming me with messages, so if I haven't looked at my phone in a while (say I'm in a movie theater watching a movie) and now I see 5 unread from one of them, chances are something non-trivial is up and they're trying to get my attention. If they were just trying to ping me, there will typically only be one (maybe two) unread from them (usually "hey" and then "you there?"). So for me, there is /some/ utility in knowing the unread count.

I like the unread/total, fwiw. But if it's not a low hanging fruit, I wouldn't pursue it right now. My $0.02

@b-abel
Copy link

b-abel commented Mar 23, 2014

I missed the message count too. Not even that everything is prepared to show the count as @McLoo states, but it had been there and was removed with commit 28c1c50. Maybe @mcginty can explain why it was removed.
Besides I fully agree with @hunleyd. It's good to see if there is only the one unread message I already know about or expect to be there, or if there is another one which could be urgent. Unfortunately displaying the count for unread messages is not as easy as the total count.

@mcginty mcginty added triage and removed triage labels Mar 25, 2014
@mcginty
Copy link
Contributor

mcginty commented Mar 25, 2014

I still don't think I totally understand the point of having a count on the conversation list for the total number of messages sent. Unread count makes sense to me, however. Somebody care to explain what they use it for?

I saw it as excessive information clutter and got rid of it.

@geileszeuch
Copy link

You are totally correct. This is not necessary at all.

On March 24, 2014 1:17:20 PM GMT-11:00, Jake McGinty notifications@github.com wrote:

I still don't think I totally understand the point of having a count on
the conversation list for the total number of messages sent. Unread
count makes sense to me, however. Somebody care to explain what they
use it for?

I saw it as excessive information clutter and got rid of it.


Reply to this email directly or view it on GitHub:
#1198 (comment)

@generalmanager
Copy link

I'm with @mcginty. Unread count makes sense, but what the hell do I need a total message count for?

@leomayer
Copy link

For me the counter makes total sense cause I get an overview how many SMS I have sent. I mean it would be nice to have an overall view so I can check as well how many SMS per month in total. For a chat I agree that's senseless. But since I cannot check what was sent via SMS or chat.....

@generalmanager
Copy link

@leomayer you'd only get the total count per month if you remember how many messages you sent last month in every thread, of if you deleted all your messages on the last day of the month.
In my opinion those SMS+data counters are a lot more useful than implementing it into TS.

@McLoo
Copy link
Contributor Author

McLoo commented Mar 25, 2014

long reply short:

  • both counters are personal taste
  • both counters got there backers here
  • depending on the your prior messenger you got used to one/both of them
  • so make them optional with the app settings
  • optimal position has to be found (behind the name, under the date, ...)

full reply text:
Mainly i use the counter to distinguish between two numbers of some of my contacts.
I send messages to contacts that have a private and work phone. So there are two message threads. the larger number indicates the private thread.

Recently i used the counter to verify the correct import into TS ;-)

Also how else would i get the information that i had 1801 messages with my mother in the last two years... (omg)

I admit that it is a personal favor having this information as well as a unread counter - which is really useful for group chats (ever opened WhatsA** and had a group chat with 30+ messages? seems to be more important than a chat with one message).

What about having both features optional - total count turned off by default?
I always got the "feeling home" in mind for people who switch their messenger.

As there is enough space underneath the date there also would be a good place for either of those counters.

thanks a lot for all of your comments!

@McLoo
Copy link
Contributor Author

McLoo commented Mar 25, 2014

may i also refer to #1055 (mark drafts in conversation list)
i think it is the same there: why have it? to much information? where show it?

@b-abel
Copy link

b-abel commented Mar 26, 2014

For me the total messages counter is indeed important. I'm with @McLoo, but like to add an explanation. I manually delete old messages from time to time (don't need to protect data which is no longer stored). In a spare minute (e.g. waiting for the bus) I choose one or two threads which I check for messages that can be deleted. Obviously I want to select threads with many messages and not those containing the single message I want to keep. Every SMS app I have used shows the count of total messages per thread, including the Android stock one.
A second usage for a total messages count is already mentioned by McLoo: it helps me to distinguish different numbers of a person.
I already had a look on the code and got a feeling how much work would it be for each of the two counters discussed here. If we should agree that they are wanted, I can offer to implement them.

@agrajaghh
Copy link
Contributor

I don't see a point in having the total message count... Its just too much information. Whatsapp and facebook messenger doesn't have them.

If you want to delete old messages, use the option where you can limit messages per thread...

If you need the number to distinguish between work and private phone numbers, this should be written, not the amount of messages (which you dont care for, because you just want to see which phone number it is...)

@leomayer
Copy link

Just my 2cents:

Since I see the discussion here, I agree with @McLoo to have an option. So, if somebody could implement with an option then I would really like to see it (read/unread/SMS/chat/whatever-counter)

On the other hand I feel uncomfortable for this issue, cause if the next programmer thinx the same way as @mcginty and just throw out the code due to personal reasons the discussion might be endless and whatever will be implemented has the high potential risk of useless/senseless. Cause I don't think all options will satisfy all developers. There will be always different ideas/opinion. And if kick-out is THAT easy....

@b-abel
Copy link

b-abel commented Apr 7, 2014

In my last comment I tried to explain that the a total messages counter is helpful for manual deletion. This obviously can not be replaced by automatic deletion. Which algorithm could ever guess that I want to keep the first SMS I received by my girlfriend but not the thousand messages since then saying "I'm a little late"?
Yes, Facebook has no total messages counter. Their business model is to collect all data of all people. Why should they show the growth of the amount of data they are collecting about you? I think this is strongly opposed to the intent of a privacy aware tool.
Of course the counter is just a step towards a convenient manual deletion process. Locking of messages (#283) and multiple selection (#786) would make it complete. This is neither new nor obsolete, it's just the way nearly every SMS app works (and I don't think @moxie0 added the counter because he had nothing else to do ;)).
Personally I'm fine with the proposal to have the counter optional. Even if I can't see a reason why we could not spare a handful of grey pixels to help users, which want to keep an eye on their personal data.

@agrajaghh
Copy link
Contributor

We have to keep in mind to keep TS simple and usable. To much information is just clutter.
How many people will delete messages by tapping them one by one based on a decision influenced by the message counter?
I really think we shouldn't made an option for everything. It just gets too confusing...

@sidnny
Copy link

sidnny commented Apr 18, 2014

It would come in handy for anyone who has a storage limit set. This way you can be aware of reaching that limit before messages start being erased.

@McLoo
Copy link
Contributor Author

McLoo commented Apr 18, 2014

good point @sidnny

@ykarm
Copy link

ykarm commented Apr 21, 2014

Since there seems to be a wide variety of preferences for different people, why not have options which cover all the bases?

Something like (in settings menu under "Appearance" sub-heading):
[+] Message counter
which when clicked on, opens a floating window with the following options:
[x] Show total message count
[x] Show unread message count

Example:
Firstnm Lastnm has message count of 101, 2 unread,
Firstnam Lastnam has message count of 89, none unread.

Case Appearance in main screen
[ ] Show total message count
[ ] Show unread message count
Firstnm Lastnm
Message Preview

Firstnam Lastnam
Message Preview
[x] Show total message count
[ ] Show unread message count
Firstnm Lastnm 101
Message Preview

Firstnam Lastnam 89
Message Preview
[ ] Show total message count
[x] Show unread message count
Firstnm Lastnm (2)
Message Preview

Firstnam Lastnam
Message Preview
[x] Show total message count
[x] Show unread message count
Firstnm Lastnm (2) 101
Message Preview

Firstnam Lastnam 89
Message Preview

And regarding the marking of drafts:
Option under "Appearance" subheading:
[x] Show drafts in message preview
Display latest draft under contact name

Firstnm Lastnm has message count of 101, 2 unread, one draft written before 2 messages recieved
Firstnam Lastnam has message count of 89, none unread, no draft.

Case Appearance in main screen
[x] Show total message count
[x] Show unread message count
[x] Show drafts in message preview
Firstnm Lastnm (2) 101
Draft: Message Draft Preview

Firstnam Lastnam 89
Message Preview
[x] Show total message count
[x] Show unread message count
[ ] Show drafts in message preview
Firstnm Lastnm (2) 101
Message Preview

Firstnam Lastnam 89
Message Preview

@mcginty mcginty added the defer label May 9, 2014
@mcginty
Copy link
Contributor

mcginty commented May 9, 2014

Like @agrajaghh there's a cost to clutter. It confuses and distracts. This is also the reason why we want to avoid extra settings. I'd be more inclined to move these counts inside a conversation info page or something like that than include it in the conversation list.

@tatwater
Copy link

+1 to @ykarm for clearly displaying the options and to this thread - I am in favor of the Show total + Show unread + Show drafts option, because it really isn't that much more clutter and I often want to know how many messages I have in given conversations. I'm also very okay with needing to enable this in Settings for it do display if the consensus is that by default it should be cleaner.

I like this information because if my phone is filling up (or if I have some free time and want to clean), I would like to be able to run through my longer threads and choose the messages to delete (also, having a message locking ability would make this process faster).

The default Android Messaging app has the thread count, and I have really appreciated having this info!

@mcginty mcginty removed their assignment Nov 16, 2015
@2-4601
Copy link
Contributor

2-4601 commented Dec 23, 2015

Signal iOS and Signal Desktop show unread counts in the conversation list.

PiCob referenced this issue Nov 14, 2017
1) Brighten background color

2) Add unread indicator in conversation list

3) Eliminate some conversation list overdraw
@moxie0
Copy link
Contributor

moxie0 commented Nov 14, 2017

I don't think we're going to add a total count, but unread count is now in 4.13.0

@moxie0 moxie0 closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests