Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing attachments #4242

Closed
johannesjh opened this issue Oct 12, 2015 · 14 comments
Closed

Allow removing attachments #4242

johannesjh opened this issue Oct 12, 2015 · 14 comments
Labels

Comments

@johannesjh
Copy link

Please add the possibility of deleting attachments from received and sent messages.

This functionality would benefit usage on devices with limited storage capacity. E.g., my personal situation is that the many pictures and videos I receive are filling up my precious storage space. I would like to delete the pictures but keep the message texts. (Also compare #4065 for a related request to allow storing messages on the external SD card).

@jeremymasters
Copy link

I just long press the message with the attachment and then delete it.

@merkste
Copy link

merkste commented Oct 12, 2015

I think the request was to remove the attachment only while preserving the text.

@johannesjh
Copy link
Author

yes, exactly. to remove the attachment only while preserving the text.

@jeff-r-koyaltech
Copy link

Other similar but slightly different use cases would call for the ability to not download the image by default. This is particularly nice when you have a group of people who feel the need to send an inspiring picture of a sunrise every morning with some sort of inspiring quote embedded into the image. Every day. Sometimes multiple times per day. :) I suppose I could always find new friends...

@mcginty
Copy link
Contributor

mcginty commented Oct 13, 2015

@langboost You can already do that. Settings -> Chats and Media -> Media auto-download.

@jeremymasters
Copy link

I think he might be talking about a per-user basis. Maybe that could work like the ringtones. All users follow the default settings unless you change that particular user's settings. Like "Never allow auto-downloads of anything from a specified user or set of users. I guess that would be more like "blocked users" but "blocked auto-download users".

@2-4601
Copy link
Contributor

2-4601 commented Oct 13, 2015

could not resist

@johannesjh
Copy link
Author

This is what the functionality for removing attachments could look like in the UI.

mockup

@bhabba
Copy link

bhabba commented Feb 4, 2016

  1. I think it would be very handy to also add a global option for auto-deletion of attachments after exceeding a certain size limit: Under Settings -> Chats and media -> Message trimming there should be an option for Delete old media where you can set a maximum storage space limit in MiB. Ideally the current free storage space of the partition where Signal's attachments are stored should be shown besides as a helpful orientation.

    When exceeding the set limit the oldest media attachments should get deleted until the total media size has fallen below the limit again.

    Of course this option should be disabled by default.

    This feature would be most useful in combination with the implementation of Feature Request: Lock Messages (to prevent auto deletion) #283 so that you are able to prevent your most precious attachments from automatically disappearing into nirvana without having to manually export and save them outside of Signal.

  2. Additionally it would be awesome to have a per conversation option as well for this (which again of course would be disabled by default). So under Conversation settings of each conversation you would find an option for Delete old media but this time in number of attachments ("keep last x media attachments"). If a global "media storage limit" was set before, an extra notice should point out that attachments might be deleted before reaching the maximum number entered here due to insufficient storage space left.

    This would be very helpful for the scenario @langboost conceives or for group chats where people randomly post attachments (mostly images) which you essentially want to open one time at most and then forget (i.e. delete). That way the tedious manual deletion of such "disk space munchers" wouldn't be necessary.

@ghost
Copy link

ghost commented Apr 16, 2016

Is there a way to quickly export all photos and videos from every chat? Preferably something that doesn't involve digging through the file system and copying folders to a desktop. Can we save to our device's photo album?

@patzi
Copy link

patzi commented Jul 20, 2016

I think the "delete all attachments" part would be a nice addition to the already included #3975. So I think this function should be at the same place as the "save all images" action and not as an extra option in the conversation menu like @johannesjh proposed in the second row of his mock-up. So this two functions on all images would be at the same spot.
Over all the longer signal installs exists the more pressing this gets :)

BTW: @Calefornia

Is there a way to quickly export all photos and videos from every chat?

I think the quick export of all images what you are looking for is what was introduced with #3975

@floriangosse
Copy link

I think #5515 is a related issue.

@notspecified
Copy link

I would also welcome a useful and working solution for the problem with decreasing storage over time through sent and received media!
I would love a solution like on the attached screenshots. Is it possible to implement this?

screenshot_2017-05-05-10-17-47
screenshot_2017-05-05-09-13-01

haffenloher added a commit to haffenloher/TextSecure that referenced this issue Sep 7, 2017
@automated-signal
Copy link

GitHub Issue Cleanup:
See #7598 for more information.

@signalapp signalapp locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.