Skip to content

Commit

Permalink
deprecate jaegergrpc (#5428)
Browse files Browse the repository at this point in the history
* deprecate jaegergrpc

* Update CHANGELOG.md

* Update internal/signalfx-agent/pkg/monitors/jaegergrpc/metadata.yaml

Co-authored-by: Curtis Robert <crobert@splunk.com>

* Update internal/signalfx-agent/pkg/monitors/jaegergrpc/monitor.go

Co-authored-by: Curtis Robert <crobert@splunk.com>

---------

Co-authored-by: Curtis Robert <crobert@splunk.com>
  • Loading branch information
atoulme and crobert-1 authored Sep 30, 2024
1 parent 8386718 commit bf8871e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### 🚩Deprecations 🚩

- (Splunk) Deprecate the jaegergrpc monitor ([#5428](https://github.com/signalfx/splunk-otel-collector/pull/5428))

## v0.110.0

This Splunk OpenTelemetry Collector release includes changes from the [opentelemetry-collector v0.110.0](https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.110.0) and the [opentelemetry-collector-contrib v0.110.0](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.110.0) releases where appropriate.
Expand Down
3 changes: 3 additions & 0 deletions internal/signalfx-agent/pkg/monitors/jaegergrpc/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
monitors:
- dimensions:
doc: |
The jaegergrpc monitor is deprecated and will be removed in a future release.
Use the Jaeger receiver instead.
Runs a GRPC server that listens for Jaeger trace batches
and forwards them to SignalFx (or the configured ingest host in the
`writer` section of the agent config). By default, the server listens on
Expand Down
1 change: 1 addition & 0 deletions internal/signalfx-agent/pkg/monitors/jaegergrpc/monitor.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ func (m *Monitor) setupListener(ctx context.Context, conf *Config) (net.Listener
// Configure the monitor and kick off volume metric syncing
func (m *Monitor) Configure(conf *Config) error {
m.logger = utils.NewThrottledLogger(log.WithFields(log.Fields{"monitorType": monitorType, "monitorID": conf.MonitorID}), 30*time.Second)
m.logger.Warn("[NOTICE] The jaegergrpc monitor is deprecated and will be removed in a future release. Use the Jaeger receiver instead.")
ctx, cancel := context.WithCancel(context.Background())
m.cancel = cancel

Expand Down

0 comments on commit bf8871e

Please sign in to comment.