-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart Agent log receiver #161
Conversation
f3d8f81
to
c81cebc
Compare
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 88.94% 88.62% -0.33%
==========================================
Files 16 16
Lines 932 958 +26
==========================================
+ Hits 829 849 +20
- Misses 73 76 +3
- Partials 30 33 +3
Continue to review full report at Codecov.
|
c81cebc
to
9320d12
Compare
logs: | ||
receivers: [smartagent/processlist] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, just to clarify. The logs pipeline is required for events to work, correct?
Do we want to document which monitors require it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's required and I will provide a list of dimension update and event using monitors w/ my next full documentation PR.
9320d12
to
130b5d3
Compare
(In lieu of #149)
These changes allow the Smart Agent receiver to act as both a metrics and logs receiver, as well as removing the notion of an event client in config and Output functionality. Instead they use standard log pipelines after I discovered that the main user of events in the agent, the processlist monitor, requires a host dimension that must be added via processor in a log pipeline unless hardcoded in agent config (open-telemetry/opentelemetry-collector-contrib#2631 is necessary in SFx exporter for this to take effect).
Also includes the basic SFx exporter dimension client defaulting logic, which is simpler without event clients.