-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux support bundle script #208
Conversation
flands
commented
Mar 29, 2021
- Update troubleshooting guide with support case details
- Move upstream troubleshooting from README.md to troubleshooting.md
- Add tests to existing installer_test
- Ensure executable - Update troubleshooting guide with support case details - Move upstream troubleshooting from README.md to troubleshooting.md - Add tests to existing installer_test
fb20635
to
4dfd66e
Compare
####################################### | ||
CONFDIR="/etc/otel/collector" # Default configuration directory | ||
DIRECTORY= # Either passed as CLI parameter or later set to CONFDIR | ||
TMPDIR="/tmp/splunk-support-bundle-$(date +%s)" # Unique temporary directory for support bundle contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's preferable to use mktemp
for staging and then produce the support tarball in the directory where the command is invoked by default w/ configurable --output
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this but feared compatibility across systems (not POSIX to my knowledge). Given installer script relies on /tmp already this felt "safe", but open to change this. @jchengsfx thoughts here?
Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 89.10% 89.10%
=======================================
Files 18 18
Lines 1010 1010
=======================================
Hits 900 900
Misses 77 77
Partials 33 33 Continue to review full report at Codecov.
|