Add SignalFx forwarder to default configs #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
requested review from
jrcamp,
flands,
tigrannajaryan,
dmitryax and
jchengsfx
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 89.10% 89.10%
=======================================
Files 18 18
Lines 1010 1010
=======================================
Hits 900 900
Misses 77 77
Partials 33 33 Continue to review full report at Codecov.
|
flands
reviewed
Mar 30, 2021
rmfitzpatrick
force-pushed
the
sa_forwarder_default_config
branch
from
5bedf50 to
a29a92e
Compare
rmfitzpatrick
force-pushed
the
sa_forwarder_default_config
branch
from
a29a92e to
d94ad33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow existing tracing library users to not need to update their instrumented deployments' configurations when using the Collector.
Also pork-barrelling layer caching on fpm image builds.