Fully adopt default collectd config directory #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcamp
approved these changes
Apr 13, 2021
rmfitzpatrick
force-pushed
the
sa_config_dir_correction
branch
from
90579e8 to
3e279d4
Compare
rmfitzpatrick
changed the title
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 86.91% 86.93% +0.01%
==========================================
Files 20 20
Lines 1490 1492 +2
==========================================
+ Hits 1295 1297 +2
Misses 160 160
Partials 35 35
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure that if the SA extension isn't used, a bundleDir-relative configDir is still used. Also corrects a typo in the dockerfile for this config field.