Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configparser package #295

Merged
merged 15 commits into from
Apr 17, 2021
Merged

Add configparser package #295

merged 15 commits into from
Apr 17, 2021

Conversation

pjanotti
Copy link
Contributor

This package will be used to implement configuration loading that will leverage config sources. This PR only includes code that was not reviewed on the core repository. This is basically the boiler-plate code needed to load config sources from the configuration file: read config sources from configuration and build them. For these, we need factory and default config settings (for the other components these are defined on core).

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #295 (7ba1d58) into main (2abffd2) will decrease coverage by 0.11%.
The diff coverage is 84.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   86.93%   86.81%   -0.12%     
==========================================
  Files          20       24       +4     
  Lines        1492     1578      +86     
==========================================
+ Hits         1297     1370      +73     
- Misses        160      173      +13     
  Partials       35       35              
Impacted Files Coverage Δ
internal/configprovider/helpers.go 0.00% <0.00%> (ø)
internal/configprovider/settings.go 75.00% <75.00%> (ø)
internal/configprovider/builder.go 100.00% <100.00%> (ø)
internal/configprovider/parser.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abffd2...7ba1d58. Read the comment docs.

@pjanotti
Copy link
Contributor Author

This one supersedes #277

@pjanotti pjanotti merged commit 689eebb into signalfx:main Apr 17, 2021
@pjanotti pjanotti deleted the add-configparser branch April 17, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants