-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configparser package #295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74b27e299a4dbe01ded8924b11ac159761916b5c.
This reverts commit 0d3d9509bc5ed0c3c88ab6d706b0f0d560893e8f.
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 86.93% 86.81% -0.12%
==========================================
Files 20 24 +4
Lines 1492 1578 +86
==========================================
+ Hits 1297 1370 +73
- Misses 160 173 +13
Partials 35 35
Continue to review full report at Codecov.
|
This one supersedes #277 |
dmitryax
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package will be used to implement configuration loading that will leverage config sources. This PR only includes code that was not reviewed on the core repository. This is basically the boiler-plate code needed to load config sources from the configuration file: read config sources from configuration and build them. For these, we need factory and default config settings (for the other components these are defined on core).