Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PATH to include smart agent bundled utilities #313

Merged
merged 4 commits into from
May 3, 2021
Merged

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Apr 20, 2021

We already ship bash, tar, curl etc. as part of smart agent bundle. Make this
easier to use by adding it to the default PATH. This allows you to exec into a
running container. (You could do this already by supplying the whole path if
you knew where they were.)

Added dependabot for dockerfiles to ensure things stay updated.

Cleanup Dockerfile.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #313 (63b0ac4) into main (237af7d) will increase coverage by 7.86%.
The diff coverage is n/a.

❗ Current head 63b0ac4 differs from pull request most recent head 4d89019. Consider uploading reports for the commit 4d89019 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   79.71%   87.57%   +7.86%     
==========================================
  Files          38       25      -13     
  Lines        2489     1915     -574     
==========================================
- Hits         1984     1677     -307     
+ Misses        458      194     -264     
+ Partials       47       44       -3     
Impacted Files Coverage Δ
internal/configprovider/helpers.go 36.36% <0.00%> (-45.46%) ⬇️
internal/configprovider/settings.go 75.00% <0.00%> (-25.00%) ⬇️
internal/configprovider/manager.go 89.88% <0.00%> (-0.38%) ⬇️
internal/components/components.go 84.00% <0.00%> (-0.22%) ⬇️
internal/configprovider/parser.go 100.00% <0.00%> (ø)
internal/configprovider/config_source_provider.go
...rnal/configsource/zookeeperconfigsource/factory.go
internal/configsource/vaultconfigsource/factory.go
internal/configsource/etcd2configsource/session.go
...configsource/zookeeperconfigsource/configsource.go
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae1eb6...4d89019. Read the comment docs.

@@ -1,18 +1,15 @@
ARG SMART_AGENT_RELEASE=v5.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the default value for SMART_AGENT_RELEASE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's set in the Makefile so removed it from here so it's not defined in multiple places.

We already ship bash, tar, curl etc. as part of smart agent bundle. Make this
easier to use by adding it to the default PATH. This allows you to exec into a
running container. (You could do this already by supplying the whole path if
you knew where they were.)

Added dependabot for dockerfiles to ensure things stay updated.

Cleanup Dockerfile.
@jrcamp jrcamp merged commit 3970962 into signalfx:main May 3, 2021
@jrcamp jrcamp deleted the dbg branch May 3, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants