-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set PATH to include smart agent bundled utilities #313
Conversation
Codecov Report
@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 79.71% 87.57% +7.86%
==========================================
Files 38 25 -13
Lines 2489 1915 -574
==========================================
- Hits 1984 1677 -307
+ Misses 458 194 -264
+ Partials 47 44 -3
Continue to review full report at Codecov.
|
cmd/otelcol/Dockerfile
Outdated
@@ -1,18 +1,15 @@ | |||
ARG SMART_AGENT_RELEASE=v5.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need the default value for SMART_AGENT_RELEASE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's set in the Makefile so removed it from here so it's not defined in multiple places.
We already ship bash, tar, curl etc. as part of smart agent bundle. Make this easier to use by adding it to the default PATH. This allows you to exec into a running container. (You could do this already by supplying the whole path if you knew where they were.) Added dependabot for dockerfiles to ensure things stay updated. Cleanup Dockerfile.
We already ship bash, tar, curl etc. as part of smart agent bundle. Make this
easier to use by adding it to the default PATH. This allows you to exec into a
running container. (You could do this already by supplying the whole path if
you knew where they were.)
Added dependabot for dockerfiles to ensure things stay updated.
Cleanup Dockerfile.