-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zookeeper config source #318
Conversation
2a68986
to
82c2534
Compare
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 79.10% 79.24% +0.14%
==========================================
Files 30 33 +3
Lines 2240 2313 +73
==========================================
+ Hits 1772 1833 +61
- Misses 423 434 +11
- Partials 45 46 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just nits and a suggestion about a README.md, see #317 (comment)
d5d1043
to
86328cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor typo on the README.md
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
No description provided.