Network interface configuration

[atoulme]

Add support for configuring the network interface on which the collector receivers will listen

[rmfitzpatrick]

You've added a new required env var without any enforcement on service startup (breaking). Please add to https://github.com/signalfx/splunk-otel-collector/blob/main/internal/settings/settings.go using the memory env vars as an example.

edit: we should be setting the default value in settings to not make it required imo***

[atoulme]

Thanks! I was also looking for good ways to test this. I caught a few failing tests. I'll take any hint on what else we can add to test.

[rmfitzpatrick]

Thanks! I was also looking for good ways to test this. I caught a few failing tests. I'll take any hint on what else we can add to test.

The settings test suite has env var helpers to detect what's set by the collector: https://github.com/signalfx/splunk-otel-collector/blob/main/internal/settings/settings_test.go#L204.

We also have a default config test that should always reflect any changes: https://github.com/signalfx/splunk-otel-collector/blob/main/tests/general/default_config_test.go. I think it's good that it didn't require any changes though I'm not 100% on what the ":<port>" addr parsing semantics are atm.

edit: missed that you did actually change the integration tests**

[jeffreyc-splunk]

We should also add the new var to the choco package as a new parameter:

• description: https://github.com/signalfx/splunk-otel-collector/blob/main/internal/buildscripts/packaging/choco/splunk-otel-collector/splunk-otel-collector.nuspec
• add and handle the new parameter: https://github.com/signalfx/splunk-otel-collector/blob/main/internal/buildscripts/packaging/choco/splunk-otel-collector/tools/chocolateyinstall.ps1

[jeffreyc-splunk]

We'll also need to add support to our deployments for the new env var when these changes are released.

settings updated

[atoulme]

Going to squash to one commit and make sure the diff makes sense.

[atoulme]

@jeffreyc-splunk please take a look when you have a moment. I am rerunning some of the ansible tests assuming that they're just flaky.

[jeffreyc-splunk]

@jeffreyc-splunk please take a look when you have a moment. I am rerunning some of the ansible tests assuming that they're just flaky.

Yeah, unfortunately virtualbox/vagrant on the github runners is flaky. May take a couple of retries to get all of those tests to pass.

[jeffreyc-splunk]

Not sure if it needs to be called out directly, but the new option in the installers will only be applicable for new installations or when the default unmodified config files are upgraded to this new version. If the customer uses a custom/modified config file, they will need to manually replace the values in their config with this env var for these changes to take effect.

[atoulme]

I can maybe call that out in a subsequent PR if you don't mind, with a changelog entry that calls out to customers how to take advantage of this if they have an existing install.