Unset exclusion and translations by default in gateway config #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our other default agent config, we are recommending sending to the gateway via OTLP. If agents are sending OTLP to the gateway, we need to do exclusions and translations at the gateway, as these would only occur if they were using the signalfx exporter.
jrcamp
approved these changes
May 3, 2021
pjanotti
referenced
this pull request
in pjanotti/splunk-otel-collector
May 4, 2021
In our other default agent config, we are recommending sending to the gateway via OTLP. If agents are sending OTLP to the gateway, we need to do exclusions and translations at the gateway, as these would only occur if they were using the signalfx exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our other default agent config, we are recommending sending
to the gateway via OTLP. If agents are sending OTLP to the gateway,
we need to do exclusions and translations at the gateway, as these
would only occur if they were using the signalfx exporter.