Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include splunk-otel-js in auto instrumentation deb/rpm #3540

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

jeffreyc-splunk
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk commented Aug 23, 2023

  • Download and include the tgz from https://github.com/signalfx/splunk-otel-js/releases in splunk-otel-auto-instrumentation deb/rpm packages
  • Include default /etc/splunk/zeroconfig_node.conf
  • Include sample systemd drop-in file with NODE_OPTIONS=-r @splunk/otel/instrument with instructions on how to manually install the splunk-otel-js package and enable/configure instrumentation for systemd services (eventually, the installers would automatically handle these steps)
  • Add gitlab job and script to update the splunk-otel-js version and open a PR (similar to splunk-otel-javaagent)
  • Requires packaging changes from Add systemd sample file to splunk-otel-auto-instrumention #3506

TODO: Add tests with node.js app

@jeffreyc-splunk jeffreyc-splunk force-pushed the new-auto-instrumentation branch 2 times, most recently from bb675a3 to 8299e20 Compare August 25, 2023 18:50
@jeffreyc-splunk jeffreyc-splunk force-pushed the new-auto-instrumentation branch from 8299e20 to a3b57c4 Compare August 28, 2023 22:28
@jeffreyc-splunk jeffreyc-splunk changed the title DNM: Include splunk-otel-js in auto instrumentation deb/rpm Include splunk-otel-js in auto instrumentation deb/rpm Aug 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the branch zero-config-dev August 29, 2023 14:30
@jeffreyc-splunk jeffreyc-splunk changed the base branch from new-auto-instrumentation to zero-config-dev August 29, 2023 14:31
@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review August 29, 2023 15:42
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners August 29, 2023 15:42
@jeffreyc-splunk jeffreyc-splunk merged commit 610bd60 into zero-config-dev Aug 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the package-splunk-otel-js branch August 29, 2023 15:43
jeffreyc-splunk added a commit that referenced this pull request Sep 1, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 1, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 7, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 8, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 14, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 21, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 25, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Sep 26, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 3, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 3, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 9, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 11, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 16, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
jeffreyc-splunk added a commit that referenced this pull request Oct 18, 2023
* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages
atoulme added a commit that referenced this pull request Oct 18, 2023
* [DNM] Zero-config C code to inject environment variables for Java and Node.js (#3514)

* Remove sending a metric as part of auto-instrumentation (#3482)

* refactor the code to inject allowed env vars

* latest after pair programming

* latest after review and pairing

* only inject env vars for java and nodejs programs. Apply env vars from different files for java and nodejs

* remove docker interactive and tty flags

* wip

* use arch var to set the name of the file to copy

* make tests pass on arm64

* try to support arm

* build for the proper platform

* fix package build

* review with Jason, test for env vars overrides

* Make ALLOWED_ENV_VARS a single string defined through the preprocessor

* Update instrumentation/tests/java/Dockerfile

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* load preload file same way as java test

* move file locations to macros

* use n functions to handle strings when possible

---------

Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>

* Add systemd sample file to splunk-otel-auto-instrumention (#3506)

* Add systemd sample file to splunk-otel-auto-instrumention

* Update manual instructions

* Include default /etc/splunk/zeroconfig_java.conf in deb/rpm packages

* Update tests for new libsplunk.so

* Run auto instrumentation workflow for the zero-config-dev branch

* Include splunk-otel-js in auto instrumentation deb/rpm (#3540)

* Add systemd sample file to splunk-otel-auto-instrumention

* Update tests for new libsplunk.so

* Include splunk-otel-js in auto instrumentation deb/rpm

* Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages

* Add tests for express instrumentation (#3566)

* Update installer script for systemd auto instrumentation (#3536)

* Rename zeroconfig config files (#3682)

* Update ZC docs and tests for manual installation/configuration (#3700)

* Update docs

* Update splunk-otel-js to v2.4.2

* Combine sample systemd config files

* Install splunk-otel-js globally for tests

* Update deps installation for node tests

* Update splunk-otel-js to v2.4.4

* Update linux-manual.md

* Update test for centos/oraclelinux 7 arm64

---------

Co-authored-by: Anna U <104845867+aurbiztondo-splunk@users.noreply.github.com>

* Update otlp endpoint for linux installer script (#3761)

* Update otlp endpoint for linux installer script

* remove 0.0.0.0

* Add debian bookworm for instrumentation tests

* Update CHANGELOG.md

---------

Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Co-authored-by: Anna U <104845867+aurbiztondo-splunk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants