Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis discovery #3731

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Redis discovery #3731

merged 13 commits into from
Oct 18, 2023

Conversation

greatestusername
Copy link
Contributor

Description:
Adds discovery mode tests and configs for redis receiver

Link to Splunk idea:
No idea link. Internal contribution

Testing:

  • Added new integration bundled test and test data
  • verified that existing redis integration tests work as intended

Documentation:

@greatestusername
Copy link
Contributor Author

Come on tests! (especially the windows tests that likely wont work because they require WSL)

Tell me what's broken in our workflow that works on my local!

@greatestusername greatestusername marked this pull request as ready for review October 11, 2023 13:43
@greatestusername greatestusername requested review from a team as code owners October 11, 2023 13:43
@greatestusername
Copy link
Contributor Author

argle new tests to investigate :D

@rmfitzpatrick
Copy link
Contributor

Mind updating the readme https://github.com/signalfx/splunk-otel-collector/blob/main/internal/confmapprovider/discovery/README.md#discovery-mode?

@greatestusername
Copy link
Contributor Author

Mind updating the readme https://github.com/signalfx/splunk-otel-collector/blob/main/internal/confmapprovider/discovery/README.md#discovery-mode?

can do!

@rmfitzpatrick rmfitzpatrick merged commit f90f9d4 into signalfx:main Oct 18, 2023
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greatestusername @rmfitzpatrick