-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed memory_ballast and making sure soft memory is set #4404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to do removal of the ballast extension from the configs in this PR or separately?
34a0c02
to
0da9267
Compare
@dmitryax Removed ballast_extension from configs. |
1c833e0
to
b45d867
Compare
Please add a changelog entry. We are planning to update the default configs here in a separate PR? We'll also need to address ansible, chef, etc. deployments after this is available. They seem to set env var for ballast size. |
As @jinja2 mentioned, we need to remove the |
2b723fa
to
e95156c
Compare
139cc13
to
d10b2d9
Compare
e272e34
to
77a535e
Compare
77a535e
to
4e5b452
Compare
internal/configconverter/testdata/without_memory_ballast_config.yaml
Outdated
Show resolved
Hide resolved
e87a1a7
to
3ed2fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
d38cafd
to
280809c
Compare
@samiura are the failing integration tests related to the change? |
280809c
to
c7e884d
Compare
@dmitryax No, if you look at the history, they have been failing ever since start of the last week. I have manually deployed this branch on my machine, kind cluster and observed the memory/cpu usage, I do not see any issues thus far. |
@dmitryax As we speak this is the state of integration test in the main branch. |
LGTM. @samiura please proceed with the follow-up cleanup as we agreed |
Description: Removed memory_ballast and making sure soft memory is set
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: