Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable $$ expansion for backward compatibility with old versions #5134

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Jul 23, 2024

Stop expanding environment variables starting with $$ in configuration files. This behavior was introduced in v0.42.0 to support a bug causing double expansion.

SPLUNK_DOUBLE_DOLLAR_CONFIG_SOURCE_COMPATIBLE controlling this behavior is removed now.

$$ is now treated as an escape sequence representing a literal $ character.

@dmitryax dmitryax marked this pull request as ready for review July 23, 2024 22:54
@dmitryax dmitryax requested review from a team as code owners July 23, 2024 22:54
@dmitryax dmitryax force-pushed the remove-double-dollar-fg branch from 9cd7208 to b483411 Compare July 23, 2024 23:01
@dmitryax dmitryax force-pushed the remove-double-dollar-fg branch from b483411 to 8007585 Compare July 23, 2024 23:24
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. I know we still have some failing TestExpandedDollarSignsViaStandardEnvVar tests but this is known and can be addressed in a separate PR.

@jvoravong jvoravong merged commit 4c3c4a4 into main Jul 25, 2024
49 of 51 checks passed
@jvoravong jvoravong deleted the remove-double-dollar-fg branch July 25, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants