Add Container ID to resource if available #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `resource.WithContainer` option to include all available information about the container an application is running in. If a container is not running in a container, this is will not add any attributes and will not alter the existing resource definitions. Fix signalfx#3355
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
=======================================
Coverage 78.98% 78.99%
=======================================
Files 88 88
Lines 3403 3404 +1
=======================================
+ Hits 2688 2689 +1
Misses 641 641
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pellared
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
resource.WithContaineroption to include all available information about the container an application is running in. If a container is not running in a container, this is will not add any attributes and will not alter the existing resource definitions.This does not add tests due to the challenge in mocking a container runtime environment. It relies on the upstream OTel testing of the
WithContaineroptions instead.Fix #3355