Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlx instrumentation #93

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Add sqlx instrumentation #93

merged 6 commits into from
Sep 28, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 10, 2021

This new module instruments the github.com/jmoiron/sqlx package. The instrumentation wraps the "github.com/jmoiron/sqlx".DB using the already existing github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql instrumentation.

  • Comply with OpenTelemetry database semantic conventions (done using the already compliant github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql instrumentation)
  • Package documentation
  • Exported objects are documented
  • Tests and linting are passing
  • Includes dependabot config
  • Library added to README.md

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #93 (8357066) into main (399ffb9) will decrease coverage by 0.10%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   87.28%   87.18%   -0.11%     
==========================================
  Files          17       18       +1     
  Lines         535      562      +27     
==========================================
+ Hits          467      490      +23     
- Misses         49       53       +4     
  Partials       19       19              
Flag Coverage Δ
Linux 87.18% <70.37%> (-0.11%) ⬇️
Windows 87.18% <70.37%> (-0.11%) ⬇️
macOS 87.18% <70.37%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entation/github.com/jmoiron/sqlx/splunksqlx/sql.go 70.37% <70.37%> (ø)
instrumentation/database/sql/splunksql/config.go 85.50% <0.00%> (+0.72%) ⬆️
instrumentation/database/sql/splunksql/sql.go 87.17% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399ffb9...8357066. Read the comment docs.

@MrAlias MrAlias marked this pull request as ready for review September 27, 2021 18:26
@MrAlias MrAlias requested review from a team as code owners September 27, 2021 18:26
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I think we only miss a notice in CHANGELOG

@MrAlias MrAlias merged commit 4143ce0 into signalfx:main Sep 28, 2021
@MrAlias MrAlias deleted the splunksqlx branch September 28, 2021 15:52
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants