Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dedicated types for Video and Fabric SDKs #1124

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Oct 5, 2024

Description

This PR:

  • Introduces a dedicated Video SDK room session, events, and a contract.
  • Introduces a dedicated Call Fabric SDK room session, events, and a contract.
  • Modifies a BaseRoomSession containing common properties from the Video and CF SDK. Now, both SDK room sessions inherit from the BaseRoomSession.
  • Fixes the Call Fabric types issues in various places.
  • Renames the CallFabric room session, events, TS types, and a contract to Fabric. E.g., the former room session was CallFabricRoomSession; it has now been renamed to FabricRoomSession. Similarly, all the types are renamed from CallFabricType to FabricType.
  • Introduces a VideoRoomSession type as well, just to be consistent across the SDKs. To make it backward compatible, the Video SDK still supports the Video.RoomSession.
  • No more stupid "ts-expect-error" for member_id and id confusion between the two SDKs.
  • Fix duplicated "member.updated" events.
  • Fix memory leak for callSegmentWorker and memberPositionWorker.
  • Enable lock/unlock room session e2e test for the CF SDK.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: 9dbeab2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@signalwire/realtime-api Patch
@signalwire/webrtc Patch
@signalwire/core Patch
@signalwire/js Patch
@signalwire/web-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7 iAmmar7 force-pushed the aa/fix-callfabric-types branch from 29ec82f to b70c914 Compare December 4, 2024 11:25
@iAmmar7 iAmmar7 changed the title WIP: CF SDK - Fix types WIP: Introduce dedicated types for Video and Fabric SDKs Dec 11, 2024
@iAmmar7 iAmmar7 changed the title WIP: Introduce dedicated types for Video and Fabric SDKs Introduce dedicated types for Video and Fabric SDKs Dec 12, 2024
@iAmmar7 iAmmar7 requested a review from jpsantosbh December 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant