-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dedicated types for Video and Fabric SDKs #1124
Open
iAmmar7
wants to merge
55
commits into
main
Choose a base branch
from
aa/fix-callfabric-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9dbeab2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iAmmar7
force-pushed
the
aa/fix-callfabric-types
branch
from
December 4, 2024 11:25
29ec82f
to
b70c914
Compare
iAmmar7
changed the title
WIP: CF SDK - Fix types
WIP: Introduce dedicated types for Video and Fabric SDKs
Dec 11, 2024
iAmmar7
changed the title
WIP: Introduce dedicated types for Video and Fabric SDKs
Introduce dedicated types for Video and Fabric SDKs
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
CallFabricRoomSession
; it has now been renamed toFabricRoomSession
. Similarly, all the types are renamed from CallFabricType to FabricType.VideoRoomSession
type as well, just to be consistent across the SDKs. To make it backward compatible, the Video SDK still supports theVideo.RoomSession
.member_id
andid
confusion between the two SDKs.callSegmentWorker
andmemberPositionWorker
.Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.