Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ajout des dépendances de test au module #18

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

pierrecamilleri
Copy link

@pierrecamilleri pierrecamilleri commented Apr 28, 2020

Lorsqu'on lance les tests, les dépendances de test sont ajoutées à go.mod et go.sum.
Je propose d'intégrer ces dépendances au go.mod, il semblerait que c'est la manière de procéder:
golang/go#26913

Fil intéressant également sur comment identifier les dépendences de test dans un module go:
golang/go#26955

PS: En fait je ne suis pas sûr de comprendre exactement ce qu'il se passe dans le go.sum, qui avait déjà des lignes pour testify et go-difflib...

Copy link

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrienjoly adrienjoly merged commit 4da3a9e into master Apr 28, 2020
@adrienjoly adrienjoly deleted the test_dependencies branch April 28, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants