Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Handbook] Migration from Notion to Storyblok #399

Merged
merged 9 commits into from
Sep 6, 2024
Merged

[Handbook] Migration from Notion to Storyblok #399

merged 9 commits into from
Sep 6, 2024

Conversation

filipeff95
Copy link
Contributor

@filipeff95 filipeff95 commented Sep 5, 2024 •
edited
Loading

Description

  • Migrated Handbook structure from Notion to Storyblok keeping the same UI.
  • Allow the same Richtext blocks as blog posts.
  • Moved 404 to separate component to include it on Handbook routes.

REVIEWER NOTES: A lot of code is the same but files moved a lot. There shouldn't be a need to thoroughly review the UI since it stayed the same.

@filipeff95 filipeff95 added the enhancement New feature or request label Sep 5, 2024
@filipeff95 filipeff95 self-assigned this Sep 5, 2024
@filipeff95 filipeff95 marked this pull request as ready for review September 5, 2024 18:52
joaogomesdev
joaogomesdev approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@joaogomesdev joaogomesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🥚🚀

@filipeff95 filipeff95 merged commit b5c88a2 into main Sep 6, 2024
2 checks passed
@filipeff95 filipeff95 deleted the feat/handbook-migration branch September 6, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaogomesdev joaogomesdev joaogomesdev approved these changes

@kaaps kaaps Awaiting requested review from kaaps

Assignees

@filipeff95 filipeff95

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipeff95 @joaogomesdev