Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly import org.jooq.Record to avoid ambiquity #783

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

damccull
Copy link
Collaborator

Supercedes #782 to change the source branch, which GitHub doesn't allow, apparently.

VS Code's java extension was complaining that the Record in each of these files was ambiguous, which makes sense because there are several available libraries that offer Record all in use in the project, but only one is valid for this case. I assume it is the jooq version since all Record instances are found in what appears to be jooq code, so I explicitly imported it, which now removes all ambiguity Errors in the java compiler.

This works and fully syncs mariadb.

Copy link
Member

@ohager ohager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohager ohager merged commit 32c5f9e into signum-network:main Jan 27, 2024
@damccull damccull deleted the explicit-import-jooq-record branch January 27, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants