-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Think about broadcast_validation
in the context of blobs
#4725
Comments
@realbigsean if I understand correctly, this is no longer an issue as blobs are no longer signed after the blob inclusion proof changes (spec)? |
@jimmygchen Not sure. Since each blob contains a |
I think our decision in #4995 is sensible. When
I think the only case we're missing is blobs received via RPC. As far as I can tell we never write these to |
I think slashability is now well covered with #5033 So I'm going to close this |
Description
The
broadcast_validation
flag exists during block publishing so that block builders/relays can guard against invalid and equivocating blocks, and halt publishing.The addition of blobs in Deneb requires careful consideration to ensure that a malicious proposer does not gain any more avenues for tricking the relay into publishing an invalid/equivocating block.
I think it's probably sufficient to just return the same kind of duplicate error that we return for blocks whenever the gossip cache for blobs is tripped, but want to just make a note of this so that we can revisit it properly.
The text was updated successfully, but these errors were encountered: