-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create unified slashing cache #5033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I can't spot any issues with this.
I'm trying to think of ways to simplify it further, as it would be great to remove observed_block_producers
and just use observed_slashable
for all blocks. I think this would require tweaking the spec conditions however, and a resolution to questions like should we propagate slashable messages in a limited way? (ethereum/consensus-specs#3561).
Squashed commit of the following: commit 924bdc9 Author: realbigsean <seananderson33@gmail.com> Date: Thu Jan 4 19:17:04 2024 -0500 don't throw error on RPC signature invalie commit acfa187 Author: realbigsean <seananderson33@gmail.com> Date: Thu Jan 4 19:05:04 2024 -0500 check header signatures for RPC blobs commit 33d51d5 Author: realbigsean <seananderson33@gmail.com> Date: Thu Jan 4 18:13:39 2024 -0500 clean up slashable cache test commit 8bd9d85 Author: realbigsean <seananderson33@gmail.com> Date: Thu Jan 4 17:47:22 2024 -0500 revert block seen cache changes commit 4c3239d Author: realbigsean <seananderson33@gmail.com> Date: Thu Jan 4 17:18:38 2024 -0500 fix broadcast validation tests commit 208bf1e Author: realbigsean <seananderson33@gmail.com> Date: Wed Jan 3 18:04:53 2024 -0500 add observed slashable file commit 3142635 Author: realbigsean <seananderson33@gmail.com> Date: Wed Jan 3 17:58:15 2024 -0500 create unified slashing cache
Thanks for the review!
I agree. If we can re-use the definition of "equivocation" from |
Issue Addressed
#5017
Changes