Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - avoid relocking head during builder health check #4323

Closed
wants to merge 2 commits into from

Conversation

int88
Copy link
Contributor

@int88 int88 commented May 23, 2023

Issue Addressed

#4314

Proposed Changes

avoid relocking head during builder health check

Additional Info

NA

@int88
Copy link
Contributor Author

int88 commented May 23, 2023

@michaelsproul PTAL.

@michaelsproul michaelsproul added optimization Something to make Lighthouse run more efficiently. v4.3.0 Estimated Q2 2023 labels May 23, 2023
@michaelsproul michaelsproul self-assigned this May 30, 2023
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Jun 22, 2023
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I wasn't able to confirm a performance-benefit from this through the (limited) benchmarking I did, I think it's a safe change to make and a nice cleanup

@michaelsproul michaelsproul added code-quality ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review optimization Something to make Lighthouse run more efficiently. labels Jun 28, 2023
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this too! I doubt it has performance benefits (like Michael said) but it's definitely less prone to weird race conditions.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 29, 2023
## Issue Addressed

#4314 

## Proposed Changes

avoid relocking head during builder health check

## Additional Info

NA
@bors
Copy link

bors bot commented Jun 29, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 29, 2023
## Issue Addressed

#4314 

## Proposed Changes

avoid relocking head during builder health check

## Additional Info

NA
@bors
Copy link

bors bot commented Jun 29, 2023

@bors bors bot changed the title avoid relocking head during builder health check [Merged by Bors] - avoid relocking head during builder health check Jun 29, 2023
@bors bors bot closed this Jun 29, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

sigp#4314 

## Proposed Changes

avoid relocking head during builder health check

## Additional Info

NA
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

sigp#4314 

## Proposed Changes

avoid relocking head during builder health check

## Additional Info

NA
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

sigp#4314 

## Proposed Changes

avoid relocking head during builder health check

## Additional Info

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ready-for-merge This PR is ready to merge. v4.3.0 Estimated Q2 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants