-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - avoid relocking head during builder health check #4323
Conversation
@michaelsproul PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I wasn't able to confirm a performance-benefit from this through the (limited) benchmarking I did, I think it's a safe change to make and a nice cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this too! I doubt it has performance benefits (like Michael said) but it's definitely less prone to weird race conditions.
bors r+ |
## Issue Addressed #4314 ## Proposed Changes avoid relocking head during builder health check ## Additional Info NA
Build failed (retrying...): |
## Issue Addressed #4314 ## Proposed Changes avoid relocking head during builder health check ## Additional Info NA
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
## Issue Addressed sigp#4314 ## Proposed Changes avoid relocking head during builder health check ## Additional Info NA
## Issue Addressed sigp#4314 ## Proposed Changes avoid relocking head during builder health check ## Additional Info NA
## Issue Addressed sigp#4314 ## Proposed Changes avoid relocking head during builder health check ## Additional Info NA
Issue Addressed
#4314
Proposed Changes
avoid relocking head during builder health check
Additional Info
NA