Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement expected withdrawals endpoint #4390

Closed
wants to merge 33 commits into from
Closed

[Merged by Bors] - Implement expected withdrawals endpoint #4390

wants to merge 33 commits into from

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Jun 10, 2023 •
edited
Loading

Issue Addressed

#4029

Proposed Changes

implement expected_withdrawals HTTP API per the spec

ethereum/beacon-APIs#304

Additional Info

@michaelsproul michaelsproul changed the title Implement expected withdrawls endpoint Implement expected withdrawals endpoint Jun 10, 2023
@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Jun 10, 2023
jimmygchen
jimmygchen reviewed Jun 20, 2023
View reviewed changes
common/eth2/src/lib.rs Outdated Show resolved Hide resolved
@jimmygchen
Copy link
Member

@eserilev thanks for this! I've added a few comments but overall looks great to me 👍

@jimmygchen jimmygchen added HTTP-API waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jun 20, 2023
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 23, 2023
@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Aug 18, 2023
@eserilev
Copy link
Collaborator Author

thanks! should be ready for another review

@jimmygchen
Copy link
Member

@eserilev changes look great!

I've triggered another CI run and looks likecargo fmt failed, you can fix this with cargo fmt --all.

jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Aug 23, 2023
@jimmygchen
Cherry-pick get expected withdrawals endpoint from sigp#4390 for testing
3108575
@eserilev
Copy link
Collaborator Author

whoops, that should be resolved now

@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 23, 2023
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Aug 23, 2023
@jimmygchen
Cherry-pick get expected withdrawals endpoint from sigp#4390 for testing
249a9d6
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Aug 23, 2023
@jimmygchen
Cherry-pick get expected withdrawals endpoint from sigp#4390 for testing
66bcc8a
jimmygchen
jimmygchen approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 😃

The cargo audit CI failure is not related to this PR, and will be addressed in #4651.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 24, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 24, 2023
@eserilev
Implement expected withdrawals endpoint (#4390)
382322e 
## Issue Addressed

[#4029](#4029)

## Proposed Changes

implement expected_withdrawals HTTP API per the spec 

ethereum/beacon-APIs#304

## Additional Info
@bors
Copy link

bors bot commented Aug 24, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 24, 2023
@eserilev
Implement expected withdrawals endpoint (#4390)
d9ae6e7 
## Issue Addressed

[#4029](#4029)

## Proposed Changes

implement expected_withdrawals HTTP API per the spec 

ethereum/beacon-APIs#304

## Additional Info
@michaelsproul
Copy link
Member

bors r-
bors r+

@bors
Copy link

bors bot commented Aug 24, 2023

Canceled.

bors bot pushed a commit that referenced this pull request Aug 24, 2023
@eserilev
Implement expected withdrawals endpoint (#4390)
661779f 
## Issue Addressed

[#4029](#4029)

## Proposed Changes

implement expected_withdrawals HTTP API per the spec 

ethereum/beacon-APIs#304

## Additional Info
@bors
Copy link

bors bot commented Aug 24, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Implement expected withdrawals endpoint [Merged by Bors] - Implement expected withdrawals endpoint Aug 24, 2023
@bors bors bot closed this Aug 24, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@eserilev @Woodpile37
Implement expected withdrawals endpoint (sigp#4390)
6fff3a4 
[sigp#4029](sigp#4029)

implement expected_withdrawals HTTP API per the spec

ethereum/beacon-APIs#304
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@eserilev @Woodpile37
Implement expected withdrawals endpoint (sigp#4390)
5228945 
[sigp#4029](sigp#4029)

implement expected_withdrawals HTTP API per the spec

ethereum/beacon-APIs#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees

@jimmygchen jimmygchen

Labels
HTTP-API ready-for-merge This PR is ready to merge. v4.4.1 ETA August 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eserilev @jimmygchen @paulhauner @michaelsproul