[Merged by Bors] - Phase 0 attestation rewards via Beacon API #4474

jimmygchen · 2023-07-06T05:03:10Z

Issue Addressed

Addresses #4026.

Beacon-API spec here.

Endpoint: POST /eth/v1/beacon/rewards/attestations/{epoch}

This endpoint already supports post-Altair epochs. This PR adds support for phase 0 rewards calculation.

Proposed Changes

Attestation rewards API to support phase 0 rewards calculation, re-using logic from state_processing. Refactored get_attestation_deltas slightly to support computing deltas for a subset of validators.
Add inclusion_delay to ideal_rewards (beacon-API spec update to follow)
Add inactivity penalties to both ideal_rewards and total_rewards (beacon-API spec update to follow)
Add tests to compute attestation rewards and compare results with beacon states

Additional Notes

The extra penalty for missing attestations or being slashed during an inactivity leak is currently not included in the API response (for both phase 0 and Altair) in the spec.
I went with adding inactivity as a separate component rather than combining them with the 4 rewards, because this is how it was grouped in the phase 0 spec. During inactivity leak, all rewards include the optimal reward, and inactivity penalties are calculated separately (see below code snippet from the spec), so it would be quite confusing if we merge them. This would also work better with Altair, because there's no "cancelling" of rewards and inactivity penalties are more separate.
Altair calculation logic (to include inactivity penalties) to be updated in a follow-up PR.

def get_attestation_deltas(state: BeaconState) -> Tuple[Sequence[Gwei], Sequence[Gwei]]:
    """
    Return attestation reward/penalty deltas for each validator.
    """
    source_rewards, source_penalties = get_source_deltas(state)
    target_rewards, target_penalties = get_target_deltas(state)
    head_rewards, head_penalties = get_head_deltas(state)
    inclusion_delay_rewards, _ = get_inclusion_delay_deltas(state)
    _, inactivity_penalties = get_inactivity_penalty_deltas(state)

    rewards = [
        source_rewards[i] + target_rewards[i] + head_rewards[i] + inclusion_delay_rewards[i]
        for i in range(len(state.validators))
    ]

    penalties = [
        source_penalties[i] + target_penalties[i] + head_penalties[i] + inactivity_penalties[i]
        for i in range(len(state.validators))
    ]

    return rewards, penalties

Example API Response

Click me

{
  "ideal_rewards": [
    {
      "effective_balance": "1000000000",
      "head": "6638",
      "target": "6638",
      "source": "6638",
      "inclusion_delay": "9783",
      "inactivity": "0"
    },
    {
      "effective_balance": "2000000000",
      "head": "13276",
      "target": "13276",
      "source": "13276",
      "inclusion_delay": "19565",
      "inactivity": "0"
    },
    {
      "effective_balance": "3000000000",
      "head": "19914",
      "target": "19914",
      "source": "19914",
      "inclusion_delay": "29349",
      "inactivity": "0"
    },
    {
      "effective_balance": "4000000000",
      "head": "26553",
      "target": "26553",
      "source": "26553",
      "inclusion_delay": "39131",
      "inactivity": "0"
    },
    {
      "effective_balance": "5000000000",
      "head": "33191",
      "target": "33191",
      "source": "33191",
      "inclusion_delay": "48914",
      "inactivity": "0"
    },
    {
      "effective_balance": "6000000000",
      "head": "39829",
      "target": "39829",
      "source": "39829",
      "inclusion_delay": "58697",
      "inactivity": "0"
    },
    {
      "effective_balance": "7000000000",
      "head": "46468",
      "target": "46468",
      "source": "46468",
      "inclusion_delay": "68480",
      "inactivity": "0"
    },
    {
      "effective_balance": "8000000000",
      "head": "53106",
      "target": "53106",
      "source": "53106",
      "inclusion_delay": "78262",
      "inactivity": "0"
    },
    {
      "effective_balance": "9000000000",
      "head": "59744",
      "target": "59744",
      "source": "59744",
      "inclusion_delay": "88046",
      "inactivity": "0"
    },
    {
      "effective_balance": "10000000000",
      "head": "66383",
      "target": "66383",
      "source": "66383",
      "inclusion_delay": "97828",
      "inactivity": "0"
    },
    {
      "effective_balance": "11000000000",
      "head": "73021",
      "target": "73021",
      "source": "73021",
      "inclusion_delay": "107611",
      "inactivity": "0"
    },
    {
      "effective_balance": "12000000000",
      "head": "79659",
      "target": "79659",
      "source": "79659",
      "inclusion_delay": "117394",
      "inactivity": "0"
    },
    {
      "effective_balance": "13000000000",
      "head": "86298",
      "target": "86298",
      "source": "86298",
      "inclusion_delay": "127176",
      "inactivity": "0"
    },
    {
      "effective_balance": "14000000000",
      "head": "92936",
      "target": "92936",
      "source": "92936",
      "inclusion_delay": "136959",
      "inactivity": "0"
    },
    {
      "effective_balance": "15000000000",
      "head": "99574",
      "target": "99574",
      "source": "99574",
      "inclusion_delay": "146742",
      "inactivity": "0"
    },
    {
      "effective_balance": "16000000000",
      "head": "106212",
      "target": "106212",
      "source": "106212",
      "inclusion_delay": "156525",
      "inactivity": "0"
    },
    {
      "effective_balance": "17000000000",
      "head": "112851",
      "target": "112851",
      "source": "112851",
      "inclusion_delay": "166307",
      "inactivity": "0"
    },
    {
      "effective_balance": "18000000000",
      "head": "119489",
      "target": "119489",
      "source": "119489",
      "inclusion_delay": "176091",
      "inactivity": "0"
    },
    {
      "effective_balance": "19000000000",
      "head": "126127",
      "target": "126127",
      "source": "126127",
      "inclusion_delay": "185873",
      "inactivity": "0"
    },
    {
      "effective_balance": "20000000000",
      "head": "132766",
      "target": "132766",
      "source": "132766",
      "inclusion_delay": "195656",
      "inactivity": "0"
    },
    {
      "effective_balance": "21000000000",
      "head": "139404",
      "target": "139404",
      "source": "139404",
      "inclusion_delay": "205439",
      "inactivity": "0"
    },
    {
      "effective_balance": "22000000000",
      "head": "146042",
      "target": "146042",
      "source": "146042",
      "inclusion_delay": "215222",
      "inactivity": "0"
    },
    {
      "effective_balance": "23000000000",
      "head": "152681",
      "target": "152681",
      "source": "152681",
      "inclusion_delay": "225004",
      "inactivity": "0"
    },
    {
      "effective_balance": "24000000000",
      "head": "159319",
      "target": "159319",
      "source": "159319",
      "inclusion_delay": "234787",
      "inactivity": "0"
    },
    {
      "effective_balance": "25000000000",
      "head": "165957",
      "target": "165957",
      "source": "165957",
      "inclusion_delay": "244570",
      "inactivity": "0"
    },
    {
      "effective_balance": "26000000000",
      "head": "172596",
      "target": "172596",
      "source": "172596",
      "inclusion_delay": "254352",
      "inactivity": "0"
    },
    {
      "effective_balance": "27000000000",
      "head": "179234",
      "target": "179234",
      "source": "179234",
      "inclusion_delay": "264136",
      "inactivity": "0"
    },
    {
      "effective_balance": "28000000000",
      "head": "185872",
      "target": "185872",
      "source": "185872",
      "inclusion_delay": "273918",
      "inactivity": "0"
    },
    {
      "effective_balance": "29000000000",
      "head": "192510",
      "target": "192510",
      "source": "192510",
      "inclusion_delay": "283701",
      "inactivity": "0"
    },
    {
      "effective_balance": "30000000000",
      "head": "199149",
      "target": "199149",
      "source": "199149",
      "inclusion_delay": "293484",
      "inactivity": "0"
    },
    {
      "effective_balance": "31000000000",
      "head": "205787",
      "target": "205787",
      "source": "205787",
      "inclusion_delay": "303267",
      "inactivity": "0"
    },
    {
      "effective_balance": "32000000000",
      "head": "212426",
      "target": "212426",
      "source": "212426",
      "inclusion_delay": "313050",
      "inactivity": "0"
    }
  ],
  "total_rewards": [
    {
      "validator_index": "0",
      "head": "212426",
      "target": "212426",
      "source": "212426",
      "inclusion_delay": "313050",
      "inactivity": "0"
    },
    {
      "validator_index": "32",
      "head": "212426",
      "target": "212426",
      "source": "212426",
      "inclusion_delay": "313050",
      "inactivity": "0"
    },
    {
      "validator_index": "63",
      "head": "-357771",
      "target": "-357771",
      "source": "-357771",
      "inclusion_delay": "0",
      "inactivity": "0"
    }
  ]
}

…ng to vec

… rewards calculation. (there are penalties for missing head votes in phase 0)

… pretty terrible bug.

jimmygchen · 2023-07-11T03:01:21Z

I broke it again 🤯 will push a fix soon.

…I don't forget.

jimmygchen · 2023-07-11T03:11:48Z

Should be good for review now! 🤞 I'm going to start testing on testnets.

michaelsproul

Really nice work! I love the code re-use and the comprehensive tests

Got a few suggestions (sorry if I rambled a bit) then I think we're good to merge 🚀

common/eth2/src/lighthouse/option_quoted_int.rs

michaelsproul · 2023-07-17T06:27:06Z

consensus/state_processing/src/per_epoch_processing/base/rewards_and_penalties.rs

    let previous_epoch = state.previous_epoch();
    let finality_delay = state
        .previous_epoch()
        .safe_sub(state.finalized_checkpoint().epoch)?
        .as_u64();

-    let mut deltas = vec![AttestationDelta::default(); state.validators().len()];
+    let mut deltas = HashMap::new();


HashMaps are quite a bit slower than Vecs for indexing, and the sort at the end is also O(n log n). I think we're sacrificing a bit too much performance here in the all-validators case to save time in the subset-of-validators case.

Instead, I'd like to propose that we keep get_attestation_deltas the same as it was previously, and take the performance hit when computing rewards for a small number of validators. On mainnet the max number of phase0 validators is 250k in epoch 74239 right before the Altair fork. Computing rewards for these 250k validators probably only takes ~50-250ms, which is not a huge saving in absolute terms, and will usually be smaller than the time required for state reconstruction (500ms+ at least). If we slow down the subset-validators case the cost (call it subset_slowdown) would be paid only by users querying small numbers of validators (slowdown x number_of_user_queries).

By comparison, if we slow down epoch processing in general (the all-validators case), then this slowdown (all_slowdown) will be paid by every archive node, at least once for every epoch transition (number_of_archive_nodes x 74k epochs x all_slowdown). The main consumers of this API (block explorers) are also likely to be making all-validators queries impacted by this slowdown. Thereofore I think the right balance is to prioritise the all-validators case for now, and we can come back to speed-up individual validator requests later if we desire (e.g. if the GUI starts using these endpoints).

PS: if we do want to keep the map approach, we should use a BTreeMap so that it retains its order during the calculation and we can avoid needing to sort it at the end.

That's a really good point, especially taking into account that the main users would be querying all validators! I agree with prioritising the all-validators case over individual validator requests and I'm convinced that we should switch back to using Vec. ~~I don't think we can use BTreeMap because the insertion order isn't by validator indices with proposer deltas being inserted in every iteration.~~ (correction: BTreeMap is sorted by key)

I've made an attempt to separate get_attestation_deltas_all and get_attestation_deltas_subset while keeping the code-reuse, I think the all-validators case now retain almost the same code path as before, and it shouldn't slow down the individual validator requests either, as we only compute the deltas for the specified indices.

This change also lead me to discover a bug in the main use case 😅 - if Vec is empty, this endpoint should return all rewards. I've updated the test and this is fixed in 81b12f0.

michaelsproul · 2023-07-17T06:28:27Z

beacon_node/beacon_chain/src/attestation_rewards.rs

+
+        let mut total_rewards = vec![];
+
+        for (index, delta) in indices_to_attestation_delta.into_iter() {


If we make the change I suggested to revert get_attestation_deltas, we can do the filtering by index here, with an .enumerate() to get the indices.

I haven't reverted get_attestation_deltas, but I've added the filtering logic to get_attestation_deltas_subset.

so now we have:

pub fn get_attestation_deltas_all: this calls into get_attestation_deltas without specifying a subset, code path should be almost identical to the previous get_attestation_deltas

pub fn get_attestation_deltas_subset: this calls into get_attestation_deltas with a specified subset, and filter the results to only include the subset

fn get_attestation_deltas: this is where the delta computation logic is, I've left this function as private because the results need to be filtered for the subset scenario, which is done in get_attestation_deltas_subset.

beacon_node/beacon_chain/src/attestation_rewards.rs

beacon_node/beacon_chain/tests/rewards.rs

… computing attestation rewards for all validators.

michaelsproul

Looks good to merge, thanks Jimmy!

michaelsproul · 2023-07-18T01:48:25Z

bors r+

## Issue Addressed Addresses #4026. Beacon-API spec [here](https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getAttestationsRewards). Endpoint: `POST /eth/v1/beacon/rewards/attestations/{epoch}` This endpoint already supports post-Altair epochs. This PR adds support for phase 0 rewards calculation. ## Proposed Changes - [x] Attestation rewards API to support phase 0 rewards calculation, re-using logic from `state_processing`. Refactored `get_attestation_deltas` slightly to support computing deltas for a subset of validators. - [x] Add `inclusion_delay` to `ideal_rewards` (`beacon-API` spec update to follow) - [x] Add `inactivity` penalties to both `ideal_rewards` and `total_rewards` (`beacon-API` spec update to follow) - [x] Add tests to compute attestation rewards and compare results with beacon states ## Additional Notes - The extra penalty for missing attestations or being slashed during an inactivity leak is currently not included in the API response (for both phase 0 and Altair) in the spec. - I went with adding `inactivity` as a separate component rather than combining them with the 4 rewards, because this is how it was grouped in [the phase 0 spec](https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/beacon-chain.md#get_attestation_deltas). During inactivity leak, all rewards include the optimal reward, and inactivity penalties are calculated separately (see below code snippet from the spec), so it would be quite confusing if we merge them. This would also work better with Altair, because there's no "cancelling" of rewards and inactivity penalties are more separate. - Altair calculation logic (to include inactivity penalties) to be updated in a follow-up PR. ```python def get_attestation_deltas(state: BeaconState) -> Tuple[Sequence[Gwei], Sequence[Gwei]]: """ Return attestation reward/penalty deltas for each validator. """ source_rewards, source_penalties = get_source_deltas(state) target_rewards, target_penalties = get_target_deltas(state) head_rewards, head_penalties = get_head_deltas(state) inclusion_delay_rewards, _ = get_inclusion_delay_deltas(state) _, inactivity_penalties = get_inactivity_penalty_deltas(state) rewards = [ source_rewards[i] + target_rewards[i] + head_rewards[i] + inclusion_delay_rewards[i] for i in range(len(state.validators)) ] penalties = [ source_penalties[i] + target_penalties[i] + head_penalties[i] + inactivity_penalties[i] for i in range(len(state.validators)) ] return rewards, penalties ``` ## Example API Response <details> <summary>Click me</summary> ```json { "ideal_rewards": [ { "effective_balance": "1000000000", "head": "6638", "target": "6638", "source": "6638", "inclusion_delay": "9783", "inactivity": "0" }, { "effective_balance": "2000000000", "head": "13276", "target": "13276", "source": "13276", "inclusion_delay": "19565", "inactivity": "0" }, { "effective_balance": "3000000000", "head": "19914", "target": "19914", "source": "19914", "inclusion_delay": "29349", "inactivity": "0" }, { "effective_balance": "4000000000", "head": "26553", "target": "26553", "source": "26553", "inclusion_delay": "39131", "inactivity": "0" }, { "effective_balance": "5000000000", "head": "33191", "target": "33191", "source": "33191", "inclusion_delay": "48914", "inactivity": "0" }, { "effective_balance": "6000000000", "head": "39829", "target": "39829", "source": "39829", "inclusion_delay": "58697", "inactivity": "0" }, { "effective_balance": "7000000000", "head": "46468", "target": "46468", "source": "46468", "inclusion_delay": "68480", "inactivity": "0" }, { "effective_balance": "8000000000", "head": "53106", "target": "53106", "source": "53106", "inclusion_delay": "78262", "inactivity": "0" }, { "effective_balance": "9000000000", "head": "59744", "target": "59744", "source": "59744", "inclusion_delay": "88046", "inactivity": "0" }, { "effective_balance": "10000000000", "head": "66383", "target": "66383", "source": "66383", "inclusion_delay": "97828", "inactivity": "0" }, { "effective_balance": "11000000000", "head": "73021", "target": "73021", "source": "73021", "inclusion_delay": "107611", "inactivity": "0" }, { "effective_balance": "12000000000", "head": "79659", "target": "79659", "source": "79659", "inclusion_delay": "117394", "inactivity": "0" }, { "effective_balance": "13000000000", "head": "86298", "target": "86298", "source": "86298", "inclusion_delay": "127176", "inactivity": "0" }, { "effective_balance": "14000000000", "head": "92936", "target": "92936", "source": "92936", "inclusion_delay": "136959", "inactivity": "0" }, { "effective_balance": "15000000000", "head": "99574", "target": "99574", "source": "99574", "inclusion_delay": "146742", "inactivity": "0" }, { "effective_balance": "16000000000", "head": "106212", "target": "106212", "source": "106212", "inclusion_delay": "156525", "inactivity": "0" }, { "effective_balance": "17000000000", "head": "112851", "target": "112851", "source": "112851", "inclusion_delay": "166307", "inactivity": "0" }, { "effective_balance": "18000000000", "head": "119489", "target": "119489", "source": "119489", "inclusion_delay": "176091", "inactivity": "0" }, { "effective_balance": "19000000000", "head": "126127", "target": "126127", "source": "126127", "inclusion_delay": "185873", "inactivity": "0" }, { "effective_balance": "20000000000", "head": "132766", "target": "132766", "source": "132766", "inclusion_delay": "195656", "inactivity": "0" }, { "effective_balance": "21000000000", "head": "139404", "target": "139404", "source": "139404", "inclusion_delay": "205439", "inactivity": "0" }, { "effective_balance": "22000000000", "head": "146042", "target": "146042", "source": "146042", "inclusion_delay": "215222", "inactivity": "0" }, { "effective_balance": "23000000000", "head": "152681", "target": "152681", "source": "152681", "inclusion_delay": "225004", "inactivity": "0" }, { "effective_balance": "24000000000", "head": "159319", "target": "159319", "source": "159319", "inclusion_delay": "234787", "inactivity": "0" }, { "effective_balance": "25000000000", "head": "165957", "target": "165957", "source": "165957", "inclusion_delay": "244570", "inactivity": "0" }, { "effective_balance": "26000000000", "head": "172596", "target": "172596", "source": "172596", "inclusion_delay": "254352", "inactivity": "0" }, { "effective_balance": "27000000000", "head": "179234", "target": "179234", "source": "179234", "inclusion_delay": "264136", "inactivity": "0" }, { "effective_balance": "28000000000", "head": "185872", "target": "185872", "source": "185872", "inclusion_delay": "273918", "inactivity": "0" }, { "effective_balance": "29000000000", "head": "192510", "target": "192510", "source": "192510", "inclusion_delay": "283701", "inactivity": "0" }, { "effective_balance": "30000000000", "head": "199149", "target": "199149", "source": "199149", "inclusion_delay": "293484", "inactivity": "0" }, { "effective_balance": "31000000000", "head": "205787", "target": "205787", "source": "205787", "inclusion_delay": "303267", "inactivity": "0" }, { "effective_balance": "32000000000", "head": "212426", "target": "212426", "source": "212426", "inclusion_delay": "313050", "inactivity": "0" } ], "total_rewards": [ { "validator_index": "0", "head": "212426", "target": "212426", "source": "212426", "inclusion_delay": "313050", "inactivity": "0" }, { "validator_index": "32", "head": "212426", "target": "212426", "source": "212426", "inclusion_delay": "313050", "inactivity": "0" }, { "validator_index": "63", "head": "-357771", "target": "-357771", "source": "-357771", "inclusion_delay": "0", "inactivity": "0" } ] } ``` </details>

bors · 2023-07-18T04:04:29Z

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Addresses sigp#4026. Beacon-API spec [here](https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getAttestationsRewards). Endpoint: `POST /eth/v1/beacon/rewards/attestations/{epoch}` This endpoint already supports post-Altair epochs. This PR adds support for phase 0 rewards calculation. - [x] Attestation rewards API to support phase 0 rewards calculation, re-using logic from `state_processing`. Refactored `get_attestation_deltas` slightly to support computing deltas for a subset of validators. - [x] Add `inclusion_delay` to `ideal_rewards` (`beacon-API` spec update to follow) - [x] Add `inactivity` penalties to both `ideal_rewards` and `total_rewards` (`beacon-API` spec update to follow) - [x] Add tests to compute attestation rewards and compare results with beacon states - The extra penalty for missing attestations or being slashed during an inactivity leak is currently not included in the API response (for both phase 0 and Altair) in the spec. - I went with adding `inactivity` as a separate component rather than combining them with the 4 rewards, because this is how it was grouped in [the phase 0 spec](https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/beacon-chain.md#get_attestation_deltas). During inactivity leak, all rewards include the optimal reward, and inactivity penalties are calculated separately (see below code snippet from the spec), so it would be quite confusing if we merge them. This would also work better with Altair, because there's no "cancelling" of rewards and inactivity penalties are more separate. - Altair calculation logic (to include inactivity penalties) to be updated in a follow-up PR. ```python def get_attestation_deltas(state: BeaconState) -> Tuple[Sequence[Gwei], Sequence[Gwei]]: """ Return attestation reward/penalty deltas for each validator. """ source_rewards, source_penalties = get_source_deltas(state) target_rewards, target_penalties = get_target_deltas(state) head_rewards, head_penalties = get_head_deltas(state) inclusion_delay_rewards, _ = get_inclusion_delay_deltas(state) _, inactivity_penalties = get_inactivity_penalty_deltas(state) rewards = [ source_rewards[i] + target_rewards[i] + head_rewards[i] + inclusion_delay_rewards[i] for i in range(len(state.validators)) ] penalties = [ source_penalties[i] + target_penalties[i] + head_penalties[i] + inactivity_penalties[i] for i in range(len(state.validators)) ] return rewards, penalties ``` <details> <summary>Click me</summary> ```json { "ideal_rewards": [ { "effective_balance": "1000000000", "head": "6638", "target": "6638", "source": "6638", "inclusion_delay": "9783", "inactivity": "0" }, { "effective_balance": "2000000000", "head": "13276", "target": "13276", "source": "13276", "inclusion_delay": "19565", "inactivity": "0" }, { "effective_balance": "3000000000", "head": "19914", "target": "19914", "source": "19914", "inclusion_delay": "29349", "inactivity": "0" }, { "effective_balance": "4000000000", "head": "26553", "target": "26553", "source": "26553", "inclusion_delay": "39131", "inactivity": "0" }, { "effective_balance": "5000000000", "head": "33191", "target": "33191", "source": "33191", "inclusion_delay": "48914", "inactivity": "0" }, { "effective_balance": "6000000000", "head": "39829", "target": "39829", "source": "39829", "inclusion_delay": "58697", "inactivity": "0" }, { "effective_balance": "7000000000", "head": "46468", "target": "46468", "source": "46468", "inclusion_delay": "68480", "inactivity": "0" }, { "effective_balance": "8000000000", "head": "53106", "target": "53106", "source": "53106", "inclusion_delay": "78262", "inactivity": "0" }, { "effective_balance": "9000000000", "head": "59744", "target": "59744", "source": "59744", "inclusion_delay": "88046", "inactivity": "0" }, { "effective_balance": "10000000000", "head": "66383", "target": "66383", "source": "66383", "inclusion_delay": "97828", "inactivity": "0" }, { "effective_balance": "11000000000", "head": "73021", "target": "73021", "source": "73021", "inclusion_delay": "107611", "inactivity": "0" }, { "effective_balance": "12000000000", "head": "79659", "target": "79659", "source": "79659", "inclusion_delay": "117394", "inactivity": "0" }, { "effective_balance": "13000000000", "head": "86298", "target": "86298", "source": "86298", "inclusion_delay": "127176", "inactivity": "0" }, { "effective_balance": "14000000000", "head": "92936", "target": "92936", "source": "92936", "inclusion_delay": "136959", "inactivity": "0" }, { "effective_balance": "15000000000", "head": "99574", "target": "99574", "source": "99574", "inclusion_delay": "146742", "inactivity": "0" }, { "effective_balance": "16000000000", "head": "106212", "target": "106212", "source": "106212", "inclusion_delay": "156525", "inactivity": "0" }, { "effective_balance": "17000000000", "head": "112851", "target": "112851", "source": "112851", "inclusion_delay": "166307", "inactivity": "0" }, { "effective_balance": "18000000000", "head": "119489", "target": "119489", "source": "119489", "inclusion_delay": "176091", "inactivity": "0" }, { "effective_balance": "19000000000", "head": "126127", "target": "126127", "source": "126127", "inclusion_delay": "185873", "inactivity": "0" }, { "effective_balance": "20000000000", "head": "132766", "target": "132766", "source": "132766", "inclusion_delay": "195656", "inactivity": "0" }, { "effective_balance": "21000000000", "head": "139404", "target": "139404", "source": "139404", "inclusion_delay": "205439", "inactivity": "0" }, { "effective_balance": "22000000000", "head": "146042", "target": "146042", "source": "146042", "inclusion_delay": "215222", "inactivity": "0" }, { "effective_balance": "23000000000", "head": "152681", "target": "152681", "source": "152681", "inclusion_delay": "225004", "inactivity": "0" }, { "effective_balance": "24000000000", "head": "159319", "target": "159319", "source": "159319", "inclusion_delay": "234787", "inactivity": "0" }, { "effective_balance": "25000000000", "head": "165957", "target": "165957", "source": "165957", "inclusion_delay": "244570", "inactivity": "0" }, { "effective_balance": "26000000000", "head": "172596", "target": "172596", "source": "172596", "inclusion_delay": "254352", "inactivity": "0" }, { "effective_balance": "27000000000", "head": "179234", "target": "179234", "source": "179234", "inclusion_delay": "264136", "inactivity": "0" }, { "effective_balance": "28000000000", "head": "185872", "target": "185872", "source": "185872", "inclusion_delay": "273918", "inactivity": "0" }, { "effective_balance": "29000000000", "head": "192510", "target": "192510", "source": "192510", "inclusion_delay": "283701", "inactivity": "0" }, { "effective_balance": "30000000000", "head": "199149", "target": "199149", "source": "199149", "inclusion_delay": "293484", "inactivity": "0" }, { "effective_balance": "31000000000", "head": "205787", "target": "205787", "source": "205787", "inclusion_delay": "303267", "inactivity": "0" }, { "effective_balance": "32000000000", "head": "212426", "target": "212426", "source": "212426", "inclusion_delay": "313050", "inactivity": "0" } ], "total_rewards": [ { "validator_index": "0", "head": "212426", "target": "212426", "source": "212426", "inclusion_delay": "313050", "inactivity": "0" }, { "validator_index": "32", "head": "212426", "target": "212426", "source": "212426", "inclusion_delay": "313050", "inactivity": "0" }, { "validator_index": "63", "head": "-357771", "target": "-357771", "source": "-357771", "inclusion_delay": "0", "inactivity": "0" } ] } ``` </details>

jimmygchen added 2 commits July 6, 2023 03:27

Draft implementation of phase0 attestation rewards for the API.

a363da1

Make inclusion_delay an Option field and add serde

e5b30e2

jimmygchen self-assigned this Jul 6, 2023

jimmygchen added the work-in-progress PR is a work-in-progress label Jul 6, 2023

jimmygchen changed the base branch from stable to unstable July 6, 2023 05:04

jimmygchen added 2 commits July 6, 2023 15:44

Add some comments for myself

bd73d05

Fix incorrect iteration logic in rewards computation.

5d9ba08

jimmygchen force-pushed the phase0-attestation-rewards branch from db54afa to 5d9ba08 Compare July 6, 2023 07:44

jimmygchen added 4 commits July 7, 2023 10:47

Fix failing tests, sort deltas map by validator indices when converti…

6fe8785

…ng to vec

Compute ideal rewards for phase0

e169c1a

Add a test for phase 0 attestation rewards calculation and fixes head…

01b9cd5

… rewards calculation. (there are penalties for missing head votes in phase 0)

Fix lints

acbdf40

jimmygchen force-pushed the phase0-attestation-rewards branch from fea9c27 to acbdf40 Compare July 10, 2023 05:46

jimmygchen added 2 commits July 10, 2023 16:51

Add inclusion_delay to ideal_rewards

8b06e34

Add inactivity penalty to phase 0 rewards calculation.

6a31eaa

jimmygchen marked this pull request as ready for review July 10, 2023 15:18

Fix lint

86d4ec6

jimmygchen added ready-for-review The code is ready for review HTTP-API and removed work-in-progress PR is a work-in-progress labels Jul 10, 2023

jimmygchen added 3 commits July 11, 2023 01:37

Add additional comment.

ddda39e

Add logic to exclude proposer delta if proposer not in subset

cc16392

Add a test for computing attestation rewards for a subset and fixed a…

da7d29c

… pretty terrible bug.

jimmygchen force-pushed the phase0-attestation-rewards branch from 7251507 to da7d29c Compare July 11, 2023 02:13

jimmygchen requested a review from michaelsproul July 11, 2023 02:16

jimmygchen added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Jul 11, 2023

Fix EF tests - same mistake again, added some additional comments so …

6cb8079

…I don't forget.

jimmygchen removed the work-in-progress PR is a work-in-progress label Jul 11, 2023

jimmygchen added the ready-for-review The code is ready for review label Jul 11, 2023

michaelsproul reviewed Jul 17, 2023

View reviewed changes

jimmygchen added 4 commits July 17, 2023 23:27

Merge branch 'unstable' into phase0-attestation-rewards

f150f34

Switch back to using Vec for computing deltas, and fixed a bug when…

81b12f0

… computing attestation rewards for all validators.

Use self.log instead of passing unnecessary Logger

629e050

Remove unnecessary mod and use Quoted instead

9a051ee

jimmygchen mentioned this pull request Jul 18, 2023

Add inactivity penalties to Altair attestation rewards endpoint response #4512

Closed

jimmygchen requested a review from michaelsproul July 18, 2023 01:23

michaelsproul approved these changes Jul 18, 2023

View reviewed changes

michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 18, 2023

bors bot changed the title ~~Phase 0 attestation rewards via Beacon API~~ [Merged by Bors] - Phase 0 attestation rewards via Beacon API Jul 18, 2023

bors bot closed this Jul 18, 2023

jimmygchen mentioned this pull request Jul 18, 2023

Attestation rewards endpoint returns error on pre-altair epochs on sepolia #4026

Closed

jimmygchen added the v4.4.1 ETA August 2023 label Jul 18, 2023

jimmygchen deleted the phase0-attestation-rewards branch July 18, 2023 10:49

jimmygchen added the backwards-incompat Backwards-incompatible API change label Jul 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Phase 0 attestation rewards via Beacon API #4474

[Merged by Bors] - Phase 0 attestation rewards via Beacon API #4474

jimmygchen commented Jul 6, 2023 •

edited

Loading

jimmygchen commented Jul 11, 2023

jimmygchen commented Jul 11, 2023

michaelsproul left a comment

michaelsproul Jul 17, 2023

jimmygchen Jul 17, 2023 •

edited

Loading

michaelsproul Jul 17, 2023

jimmygchen Jul 17, 2023

michaelsproul Jul 18, 2023

michaelsproul left a comment

michaelsproul commented Jul 18, 2023

bors bot commented Jul 18, 2023


		let mut total_rewards = vec![];

		for (index, delta) in indices_to_attestation_delta.into_iter() {

[Merged by Bors] - Phase 0 attestation rewards via Beacon API #4474

[Merged by Bors] - Phase 0 attestation rewards via Beacon API #4474

Conversation

jimmygchen commented Jul 6, 2023 • edited Loading

Issue Addressed

Proposed Changes

Additional Notes

Example API Response

jimmygchen commented Jul 11, 2023

jimmygchen commented Jul 11, 2023

michaelsproul left a comment

Choose a reason for hiding this comment

michaelsproul Jul 17, 2023

Choose a reason for hiding this comment

jimmygchen Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

michaelsproul Jul 17, 2023

Choose a reason for hiding this comment

jimmygchen Jul 17, 2023

Choose a reason for hiding this comment

michaelsproul Jul 18, 2023

Choose a reason for hiding this comment

michaelsproul left a comment

Choose a reason for hiding this comment

michaelsproul commented Jul 18, 2023

bors bot commented Jul 18, 2023

jimmygchen commented Jul 6, 2023 •

edited

Loading

jimmygchen Jul 17, 2023 •

edited

Loading