[Merged by Bors] - Update blst to 0.3.11 #4624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
|
Should we also be bumping the version here https://github.com/michaelsproul/lighthouse/blob/blst-0.3.11/crypto/bls/Cargo.toml#L20 |
|
@pawanjay176 we haven't bothered to in the past because it's a semver compatible update. I guess we could if we want to ensure people using crypto/bls externally as a dependency get the updated version |
|
Ohh wow did not know that we could do that. Thanks for the explanation! |
|
Nice! Will the |
It'll take the spicy-opcodes path as it does today, the feature in blst is called |
paulhauner
added
ready-for-merge
|
Pushed a new commit to ignore the cargo audit failure until #4623 can be properly patched. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Proposed Changes This PR updates `blst` to 0.3.11, which gives us _runtime detection of CPU features_ 🎉 Although [performance benchmarks](https://gist.github.com/michaelsproul/f759fa28dfa4003962507db34b439d6c) don't show a substantial detriment to running the `portable` build vs `modern`, in order to take things slowly I propose the following roll-out strategy: - Keep both `modern` and `portable` builds for releases/Docker images. - Run the `portable` build on half of SigP's infrastructure to monitor for performance deficits. - Listen out for user issues with the `portable` builds (e.g. SIGILLs from misdetected hardware). - Make the `portable` build the default and remove the `modern` build from our release binaries & Docker images.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Proposed Changes This PR updates `blst` to 0.3.11, which gives us _runtime detection of CPU features_ 🎉 Although [performance benchmarks](https://gist.github.com/michaelsproul/f759fa28dfa4003962507db34b439d6c) don't show a substantial detriment to running the `portable` build vs `modern`, in order to take things slowly I propose the following roll-out strategy: - Keep both `modern` and `portable` builds for releases/Docker images. - Run the `portable` build on half of SigP's infrastructure to monitor for performance deficits. - Listen out for user issues with the `portable` builds (e.g. SIGILLs from misdetected hardware). - Make the `portable` build the default and remove the `modern` build from our release binaries & Docker images.
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
## Proposed Changes This PR updates `blst` to 0.3.11, which gives us _runtime detection of CPU features_ 🎉 Although [performance benchmarks](https://gist.github.com/michaelsproul/f759fa28dfa4003962507db34b439d6c) don't show a substantial detriment to running the `portable` build vs `modern`, in order to take things slowly I propose the following roll-out strategy: - Keep both `modern` and `portable` builds for releases/Docker images. - Run the `portable` build on half of SigP's infrastructure to monitor for performance deficits. - Listen out for user issues with the `portable` builds (e.g. SIGILLs from misdetected hardware). - Make the `portable` build the default and remove the `modern` build from our release binaries & Docker images.
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Proposed Changes This PR updates `blst` to 0.3.11, which gives us _runtime detection of CPU features_ 🎉 Although [performance benchmarks](https://gist.github.com/michaelsproul/f759fa28dfa4003962507db34b439d6c) don't show a substantial detriment to running the `portable` build vs `modern`, in order to take things slowly I propose the following roll-out strategy: - Keep both `modern` and `portable` builds for releases/Docker images. - Run the `portable` build on half of SigP's infrastructure to monitor for performance deficits. - Listen out for user issues with the `portable` builds (e.g. SIGILLs from misdetected hardware). - Make the `portable` build the default and remove the `modern` build from our release binaries & Docker images.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
This PR updates `blst` to 0.3.11, which gives us _runtime detection of CPU features_ 🎉 Although [performance benchmarks](https://gist.github.com/michaelsproul/f759fa28dfa4003962507db34b439d6c) don't show a substantial detriment to running the `portable` build vs `modern`, in order to take things slowly I propose the following roll-out strategy: - Keep both `modern` and `portable` builds for releases/Docker images. - Run the `portable` build on half of SigP's infrastructure to monitor for performance deficits. - Listen out for user issues with the `portable` builds (e.g. SIGILLs from misdetected hardware). - Make the `portable` build the default and remove the `modern` build from our release binaries & Docker images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR updates
blstto 0.3.11, which gives us runtime detection of CPU features 🎉Although performance benchmarks don't show a substantial detriment to running the
portablebuild vsmodern, in order to take things slowly I propose the following roll-out strategy:modernandportablebuilds for releases/Docker images.portablebuild on half of SigP's infrastructure to monitor for performance deficits.portablebuilds (e.g. SIGILLs from misdetected hardware).portablebuild the default and remove themodernbuild from our release binaries & Docker images.