Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - restore cargo vendor in test suite #4886

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - restore cargo vendor in test suite #4886

wants to merge 1 commit into from

Conversation

realbigsean
Copy link
Member

Issue Addressed

resolves #4440

Proposed Changes

restore our cargo vendor test in CI

changes to c-kzg here mean we no longer have to compile it twice and get duplicate source errors: #4862

@realbigsean realbigsean added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! deneb labels Oct 26, 2023
pawanjay176
pawanjay176 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, glad we can get this out of the way now 🎉

@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 26, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 27, 2023
@realbigsean
restore cargo vendor in test suite (#4886)
cf5686a 
## Issue Addressed

resolves #4440

## Proposed Changes

restore our `cargo vendor` test in CI

changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862

Co-authored-by: realbigsean <seananderson33@gmail.com>
@bors
Copy link

bors bot commented Oct 27, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 27, 2023
@realbigsean
restore cargo vendor in test suite (#4886)
90c1722 
## Issue Addressed

resolves #4440

## Proposed Changes

restore our `cargo vendor` test in CI

changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862

Co-authored-by: realbigsean <seananderson33@gmail.com>
@bors
Copy link

bors bot commented Oct 27, 2023

Build failed:

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Oct 27, 2023
@realbigsean
restore cargo vendor in test suite (#4886)
a9f9dc2 
## Issue Addressed

resolves #4440

## Proposed Changes

restore our `cargo vendor` test in CI

changes to `c-kzg` here mean we no longer have to compile it twice and get duplicate source errors: #4862

Co-authored-by: realbigsean <seananderson33@gmail.com>
@bors
Copy link

bors bot commented Oct 27, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title restore cargo vendor in test suite [Merged by Bors] - restore cargo vendor in test suite Oct 27, 2023
@bors bors bot closed this Oct 27, 2023
@realbigsean realbigsean mentioned this pull request Nov 7, 2023
Closed
@realbigsean realbigsean deleted the restore-cargo-vendor-in-test-suite branch November 21, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
deneb low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realbigsean @michaelsproul @pawanjay176