Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more block v3 tests #4939

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add more block v3 tests #4939

merged 3 commits into from
Nov 21, 2023

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

#4905

Proposed Changes

Include tests that check blinded/non-blinded scenarios

Additional Info

  • The tests panic if the wrong block type is returned, no need to check the local cache
  • Updated test_builder_works_post_deneb to use the v3 endpoint

@jimmygchen jimmygchen added test improvement Improve tests ready-for-review The code is ready for review labels Nov 21, 2023
realbigsean
realbigsean approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @eserilev !

@realbigsean realbigsean merged commit e856a90 into sigp:unstable Nov 21, 2023
24 checks passed
@realbigsean realbigsean mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eserilev @realbigsean @jimmygchen