Enable progressive balances fast mode by default #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
optimization
|
I think we're missing the actual change here: |
|
Good catch, thanks @jimmygchen! Fixed in my latest commit |
|
CI passed except for a flaky test (address in use)! Let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since we added the progressive balances cache in #4362 there haven't been any issues on our infra or reported by users. I think it's time we take advantage of the cache and actually bring its benefits to users.
Additional Info
In
tree-statesthe cache is used by default with no option to turn it off. Enablingfastby default on stable paves the way for that.There was a bug in the progressive-balances cache on
tree-states(#4834), but it was related to changes I'd made and not to the inherent implementation. The fuzzing of thetree-statesbranch is also exercising the cache and is yet to unearth any issues.