Fix block v3 reward encodings #5049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
paulhauner
approved these changes
Jan 9, 2024
Cargo.toml
Outdated
| @@ -110,7 +110,9 @@ env_logger = "0.9" | |||
| error-chain = "0.12" | |||
| ethereum-types = "0.14" | |||
| ethereum_hashing = "1.0.0-beta.2" | |||
| ethereum_serde_utils = "0.5" | |||
| # ethereum_serde_utils = "0.5" | |||
| # FIXME(sproul): restore crates.io version | |||
There was a problem hiding this comment.
I've approved that PR over in ethereum_serde_utils
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Jan 9, 2024
Squashed commit of the following: commit cfb0994 Author: Michael Sproul <michael@sigmaprime.io> Date: Tue Jan 9 15:59:25 2024 +1100 Fix block v3 reward encodings
Merged
|
Updated and ready to merge if CI passes |
michaelsproul
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
consensus_block_valuein wei units rather than gwei (see: Clarify that payload & block values are in Wei ethereum/beacon-APIs#400).Additional Info
Needs a new release of
ethereum_serde_utils. The PR to that repo that needs reviewing alongside this is sigp/ethereum_serde_utils#5.