-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cli option for the snapshot cache size #5270
Conversation
0babffd
to
2ef11ad
Compare
Some metrics I collected from Holesky last week and forgot to post. Resident set size (RSS) has lower peaks: Blue = cache size 3, yellow = cache size 4 Memory usage is still correlated with snapshot cache size, which is being effectively limited: Blue = cache size 3, yellow = cache size 4 RSS for cache size 2 is also good: The main risk of dropping the snapshot cache size is increasing the frequency of snapshot cache misses. Unfortunately on Holesky these are already very frequent, although our changes do not seem to make it worse: Snapshot cache misses over 7d with cache size=2 from ~Feb 22 12pm (above) Snapshot cache misses over 7d with cache size=3 from ~Feb 22 12pm (above) Snapshot cache misses over 7d with cache size=4 |
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@Mergifyio dequeue |
✅ The pull request has been removed from the queue
|
@Mergifyio requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3ab9d3a |
Issue Addressed
N/A
Proposed Changes
Adds a cli option
--state-cache-size
to change the size of the snapshot cache.Also makes the default size 3 instead of 4.