Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cli option for the snapshot cache size #5270

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Adds a cli option --state-cache-size to change the size of the snapshot cache.
Also makes the default size 3 instead of 4.

@michaelsproul
Copy link
Member

Some metrics I collected from Holesky last week and forgot to post.

Resident set size (RSS) has lower peaks:

3vs4_resident

Blue = cache size 3, yellow = cache size 4

Memory usage is still correlated with snapshot cache size, which is being effectively limited:

3vs4_snapshots

Blue = cache size 3, yellow = cache size 4

RSS for cache size 2 is also good:

2vs4_resident

The main risk of dropping the snapshot cache size is increasing the frequency of snapshot cache misses. Unfortunately on Holesky these are already very frequent, although our changes do not seem to make it worse:

2_snapshot_cache_misses

Snapshot cache misses over 7d with cache size=2 from ~Feb 22 12pm (above)

3_snapshot_cache_misses

Snapshot cache misses over 7d with cache size=3 from ~Feb 22 12pm (above)

4_snapshot_cache_misses

Snapshot cache misses over 7d with cache size=4

@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Feb 25, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5270 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 25, 2024
mergify bot added a commit that referenced this pull request Feb 25, 2024
@michaelsproul
Copy link
Member

@Mergifyio dequeue

Copy link

mergify bot commented Feb 26, 2024

dequeue

✅ The pull request has been removed from the queue default

@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Feb 26, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 26, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3ab9d3a

mergify bot added a commit that referenced this pull request Feb 26, 2024
mergify bot added a commit that referenced this pull request Feb 26, 2024
@mergify mergify bot merged commit 3ab9d3a into sigp:unstable Feb 26, 2024
30 checks passed
mergify bot added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v5.1.0 Q2 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants