Remove VC response signing and fix HTTP error handling

[eserilev]

Issue Addressed

#4597 and #5423

Proposed Changes

• Removed VC response signing and related code paths
• prevent warp backtracking issues by changing our usage of and_then to then

Closes #4597
Closes #5423

[eserilev]

I've reverted some of my deletions and refactored a few things

Removing VC response signing

I've removed VC response signing which makes VC response error handling much simpler. Everything is now wrapped in a blocking_json_task which also converts warp errors into Responses to prevent weird warp backtrace nonsense

VC Auth header

I've reverted the changes that removed VC auth header logic.

We just need to change the authentication token to an arbitrary byte string, rather than a token derived from the server's signing key.

In ApiSecret::create_or_open

lighthouse/validator_client/src/http_api/api_secret.rs

Lines 45 to 47 in afccdf8

	if !pk_path.exists() {
	let sk = SecretKey::random(&mut thread_rng());
	let pk = PublicKey::from_secret_key(&sk);

This little snippet already randomly generates an auth token. I've removed the following logic

• Generating the server signing key from the api token
• Storing/loading the server signing key on/from disk
• Checking that the server signing key and api token are a valid key pair

I've also ensured that we're still backwards compatible, by loading the api token from disk if it already exists

[michaelsproul]

Looking good! I think we can get this in for v5.2.0 pretty soon

[michaelsproul]

Looks great, let's do it!

[michaelsproul]

Marking as backwards-incompat because removing the Signature header is technically a breaking change for the ~0 users who care about this 😁

Let's merge

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at bf2f0b0