Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce code duplication and remove unnecesary strings #5762

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

refactor: reduce code duplication and remove unnecesary strings #5762

wants to merge 2 commits into from
+8 −75

Conversation

1010adigupta
Copy link

Issue Addressed

closes #5745

Proposed Changes

modifies code according to issue description, removes some boilerplate comments and reduces code duplication.

@CLAassistant
Copy link

CLAassistant commented May 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@1010adigupta
Copy link
Author

if some other comments need to be removed then kindly tell

@chong-he chong-he added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels May 10, 2024
dapplion
dapplion reviewed May 11, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping onto this @1010adigupta, some nits

beacon_node/lighthouse_network/src/rpc/methods.rs Outdated
LightClientBootstrap(Arc<LightClientBootstrap<T>>),

/// A response to a get BLOBS_BY_ROOT request.
BlobsByRoot(Arc<BlobSidecar<T>>),

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the whitespace too. Also ResponseTermination variant comments can be dropped too

beacon_node/lighthouse_network/src/rpc/protocol.rs Outdated
#[strum(serialize = "beacon_blocks_by_root")]
BlocksByRoot,
/// The `BlobsByRange` protocol name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the whitespaces for the enums your PR is already modifying

@1010adigupta
Copy link
Author

@chong-he all suggested changes have been addressed, can merge

@jimmygchen jimmygchen changed the base branch from stable to unstable May 29, 2024 07:09
@jimmygchen
Copy link
Member

Hi @1010adigupta
Latest development is happening on the unstable branch, and all PRs should target unstable. I've modified the target branch of this PR.

However it looks like this was built on top of stable, could you please make the changes on unstable instead? Thanks!

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 12, 2024
@chong-he
Copy link
Member

@1010adigupta Could you please merge the latest unstable to update this PR and solve the conflicts, as @jimmygchen mentioned?

There are some light client RPCs (#3849) that are in the latest unstable. Need to merge the fields related to LightClientOptimisticUpdate and LightClientFinalityUpdate to your PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop some boilerplate in lighthouse_network
5 participants
@1010adigupta @CLAassistant @jimmygchen @chong-he @dapplion