-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requires suggested-fee-recipient
flag when always-prepare-payload
is set
#6079
Conversation
Based on the test failure it seems like |
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3859c9b |
Currently, when the flag
--always-prepare-payload
is set and a fee recipient is not set in the beacon node, the beacon node will print the log:CRIT Fee recipient unknown proposer_index: 368409, msg: the suggested_fee_recipient was unknown during block production. a junk address was used, rewards were lost! check the --suggested-fee-recipient flag and VC configuration., service: exec
which can be noisy and not desirable. This PR changes it so that the flag
--suggested-fee-recipient
must always be set when--always-prepare-payload
is set. The documentation is also updated to reflect this change.Thanks to the discussion raised by @just_in_time and @michaelsproul in Discord