-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize validator store #6705
Draft
dknopik
wants to merge
15
commits into
sigp:unstable
Choose a base branch
from
dknopik:modularize-validator-store
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ThreeHrSleep <threehrsleep@gmail.com>
Co-authored-by: ThreeHrSleep <threehrsleep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for modularizing the validator store so that we can reuse the validator services in Anchor. It is very work in progress. :)
Proposed Changes
ValidatorStore
with all functions used by thevalidator_services
validator_services
generic onS: ValidatorStore
LighthouseValidatorStore
, which has identical functionality to the oldValidatorStore
environment
) fromvalidator_services
andbeacon_node_fallback
in order to be able to cleanly use them in AnchorAdditional Info
This is dependent on the tracing integration changes (#6339) - for development, I pulled in some changes manually in the required places. This breaks Lighthouse, so I have not yet tried running Lighthouse with these changes.