Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize validator store #6705

Draft
wants to merge 15 commits into
base: unstable
Choose a base branch
from

Conversation

dknopik
Copy link
Contributor

@dknopik dknopik commented Dec 16, 2024

This is a draft PR for modularizing the validator store so that we can reuse the validator services in Anchor. It is very work in progress. :)

Proposed Changes

  • Create trait ValidatorStore with all functions used by the validator_services
  • Make validator_services generic on S: ValidatorStore
  • Introduce LighthouseValidatorStore, which has identical functionality to the old ValidatorStore
  • Remove dependencies (especially environment) from validator_services and beacon_node_fallback in order to be able to cleanly use them in Anchor

Additional Info

This is dependent on the tracing integration changes (#6339) - for development, I pulled in some changes manually in the required places. This breaks Lighthouse, so I have not yet tried running Lighthouse with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant