Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error handling to startup logic #239

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

antondlr
Copy link
Member

solves a couple issues on #238 : namely

  • provide default .env file if none provided
  • better error handling on startup (i.e., APIs unavailable)

additionally, the final docker image is cleaner (less layers)

@antondlr antondlr changed the base branch from stable to unstable June 22, 2024 19:55
@antondlr
Copy link
Member Author

example output of

  • BN connection not availabe
  • VC connection available but wrong token provided
http://host.docker.internal:5052 unreachable, check settings and connection
validator api issue, server response: 403

@antondlr
Copy link
Member Author

example output when no .env file found


No `/.env` file found at the expected location (`/app/.env`).
Please adapt this default file to your needs and mount it within the container:
----------------
PORT=3000
BACKEND_URL=http://127.0.0.1:3001
BEACON_URL=http://your-BN-ip:5052
VALIDATOR_URL=http://your-VC-ip:5062
API_TOKEN=get-it-from-'.lighthouse/validators/api-token.txt'
SESSION_PASSWORD="your-password"
SSL_ENABLED=true
----------------

@antondlr
Copy link
Member Author

@chong-he
are these startup-failures verbose enough for you to assist?

Copy link
Member

@rickimoore rickimoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antondlr antondlr merged commit ee1c79c into sigp:unstable Jun 24, 2024
rickimoore pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants