Feat: Enable Deposits #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickimoore
force-pushed
the
feat/deposits
branch
from
5291e65 to
cf4269b
Compare
…d of manually adding them
AgeManning
reviewed
Dec 5, 2024
|
|
||
| interface DepositDataJson { | ||
| amount: number | ||
| pubkey: string |
There was a problem hiding this comment.
I saw in the previous file there was a Pubkey Type. If we can we should use the actual types to avoid invalid data
| interface DepositDataJson { | ||
| amount: number | ||
| pubkey: string | ||
| signature: string |
There was a problem hiding this comment.
Similarly here, this should be a signature type (if it exists). Should be a bls sig.
| amount: number | ||
| pubkey: string | ||
| signature: string | ||
| withdrawal_credentials: string |
There was a problem hiding this comment.
This should be a hash, pretty sure. Should be the correct hash type if possible.
| } | ||
|
|
||
| interface DepositData extends DepositDataJson { | ||
| deposit_data_root: string |
| generateDepositData: ( | ||
| mnemonic: string, | ||
| index: number, | ||
| withdrawalAddress: string, |
| const generateDepositData = async ( | ||
| mnemonic: string, | ||
| index: number, | ||
| withdrawalAddress: string, |
| isLoading: boolean | ||
| error: string | ||
| keyStore: KeyStoreData | undefined | ||
| pubKey: string |
dapplion
reviewed
Dec 9, 2024
This was referenced Dec 12, 2024
Closed
Closed
rickimoore
added a commit
that referenced
this pull request
Dec 17, 2024
Co-authored-by: antondlr <anton@delaruelle.net>
AgeManning
pushed a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: antondlr <anton@delaruelle.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of creating and reading mnemonics, creation of BLS validator keys, deposit json and allowing uses to deposit via the CLI.
Care needs to be taken to ensure the deposit contract address is clearly written and printed to the UI so users can verify the address before sending and money.
#255