Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buildkite provider #2778

Closed
haydentherapper opened this issue Mar 8, 2023 · 1 comment · Fixed by #2779
Closed

Add Buildkite provider #2778

haydentherapper opened this issue Mar 8, 2023 · 1 comment · Fixed by #2779
Assignees
@haydentherapper
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

Fulcio now has support for issuing certificates for identities from Buildkite, and this has been rolled out to production. We should add a provider to support fetching an identity token from an environment variable or API call.

cc @sj26 @mattmoor
@haydentherapper haydentherapper added the enhancement New feature or request label Mar 8, 2023
@mattmoor
Copy link
Member

mattmoor commented Mar 8, 2023

Yeah, this would be awesome. I'm not sure how well it is surfaced as SDK, but a library form of:

buildkite-agent oidc request-token --audience sigstore

... would be 🔥

@haydentherapper haydentherapper self-assigned this Mar 8, 2023
@haydentherapper haydentherapper mentioned this issue Mar 8, 2023
Merged
haydentherapper added a commit to haydentherapper/cosign that referenced this issue Mar 8, 2023
@haydentherapper
Add Buildkite provider
717fcd3 
Inspired by
https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go,
this should replicate the logic used when calling
'buildkite-agent oidc request-token'

Fixes sigstore#2778

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper added a commit to haydentherapper/cosign that referenced this issue Mar 8, 2023
@haydentherapper
Add Buildkite provider
88db6a7 
Inspired by
https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go,
this should replicate the logic used when calling
'buildkite-agent oidc request-token'

Fixes sigstore#2778

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
cpanato pushed a commit that referenced this issue Mar 9, 2023
@haydentherapper
Add Buildkite provider (#2779)
6ca4ffd 
* Add Buildkite provider

Inspired by
https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go,
this should replicate the logic used when calling
'buildkite-agent oidc request-token'

Fixes #2778

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Support customizing log level based on env var

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

---------

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dmitris pushed a commit to dmitris/cosign that referenced this issue Mar 24, 2023
@haydentherapper @dmitris
Add Buildkite provider (sigstore#2779)
3d95c5b 
* Add Buildkite provider

Inspired by
https://github.com/buildkite/agent/blob/main/clicommand/oidc_request_token.go,
this should replicate the logic used when calling
'buildkite-agent oidc request-token'

Fixes sigstore#2778

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Support customizing log level based on env var

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

---------

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haydentherapper haydentherapper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Buildkite provider haydentherapper/cosign
2 participants
@mattmoor @haydentherapper