Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts are non-deterministic #3120

Closed
jonjohnsonjr opened this issue Jul 19, 2023 · 1 comment · Fixed by #3121
Closed

Artifacts are non-deterministic #3120

jonjohnsonjr opened this issue Jul 19, 2023 · 1 comment · Fixed by #3121
Labels
bug Something isn't working

Comments

@jonjohnsonjr
Copy link
Contributor

Description

This effectively reverts #2108

Determinism is a feature, not a bug. Libraries should not depend on external, global, mutable state (time.Now()).

Once this is fixed, I will reopen #522, and (if someone wants) they can plumb an option through that sets the time.

Version

Since #522

@jonjohnsonjr jonjohnsonjr added the bug Something isn't working label Jul 19, 2023
@Akaame
Copy link

Akaame commented Jul 21, 2023

It seems there were arguments regarding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants