Fix nondeterminsitic timestamps #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not (by default) be making the artifacts we produce nondeterministic. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #3121 +/- ##
=======================================
Coverage 30.64% 30.64%
=======================================
Files 155 155
Lines 9791 9775 -16
=======================================
- Hits 3000 2996 -4
+ Misses 6341 6333 -8
+ Partials 450 446 -4
|
bobcallaway
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not (by default) be making the artifacts we produce nondeterministic.
Summary
Fixes #3120