Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile section of README #2323

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp commented Oct 10, 2022

Signed-off-by: Alex Cameron asc@tetsuo.sh

Summary

Update the Dockerfile section of the README.

Release Note

NONE.

Signed-off-by: Alex Cameron <asc@tetsuo.sh>
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpanato cpanato merged commit d2f77e6 into sigstore:main Oct 10, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Oct 10, 2022
@lukehinds
Copy link
Member

lukehinds commented Oct 11, 2022

I am not following what this change is achieving, why is the extra FROM needed and why are we introducing another registry?

@tetsuo-cpp
Copy link
Contributor Author

I am not following what this change is achieving, why is the extra FROM needed and why are we introducing another registry?

My understanding is that the second FROM is the base image for this Dockerfile. It's a minimal container that has just enough to run the Cosign binary.

As for why I've changed the registry, the infrastructure has been moved from distroless to chainguard-images. If you click through to the distroless GitHub org, there is some advice in the README that says:

Distroless images have moved to the Chainguard Images repo.

Please update any image references to use the cgr.dev/chainguard registry i.e. docker pull distroless.dev/static is now docker pull cgr.dev/chainguard/static.

@tetsuo-cpp tetsuo-cpp deleted the alex/docker-readme branch October 11, 2022 09:41
@lukehinds
Copy link
Member

It was at ghcr.io before though?

@tetsuo-cpp
Copy link
Contributor Author

It was at ghcr.io before though?

Ah right. Perhaps the images are pushed to both registries? In any case, cgr.dev is the one listed in the README of the image repo.

@lukehinds
Copy link
Member

lukehinds commented Oct 11, 2022

My two cents is we should dog food here, build code on gh, push to ghcr, and recommend users pull from ghcr. I don't see a lot of value of introducing another layer of infra.

Ah right. Perhaps the images are pushed to both registries? In any case, cgr.dev is the one listed in the README of the image repo.

Not sure I am following why that's relevant? Its listed there, as that is for chainguard images.

@lukehinds
Copy link
Member

Ok, I got it, distroless has been shift and lifted over to chainguard. T.I.L.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants