-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile section of README #2323
Conversation
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
d78f527
to
220e29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not following what this change is achieving, why is the extra FROM needed and why are we introducing another registry? |
My understanding is that the second FROM is the base image for this Dockerfile. It's a minimal container that has just enough to run the Cosign binary. As for why I've changed the registry, the infrastructure has been moved from distroless to chainguard-images. If you click through to the distroless GitHub org, there is some advice in the README that says:
|
It was at ghcr.io before though? |
Ah right. Perhaps the images are pushed to both registries? In any case, |
My two cents is we should dog food here, build code on gh, push to ghcr, and recommend users pull from ghcr. I don't see a lot of value of introducing another layer of infra.
Not sure I am following why that's relevant? Its listed there, as that is for chainguard images. |
Ok, I got it, distroless has been shift and lifted over to chainguard. T.I.L. |
Signed-off-by: Alex Cameron asc@tetsuo.sh
Summary
Update the Dockerfile section of the README.
Release Note
NONE.