-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind flags as prefixed env variables #2346
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2346 +/- ##
==========================================
- Coverage 29.87% 29.70% -0.17%
==========================================
Files 134 134
Lines 8289 8335 +46
==========================================
Hits 2476 2476
- Misses 5482 5528 +46
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
81366a8
to
3f94ed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @hectorj2f !!
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
3f94ed3
to
dcd2bd9
Compare
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool
Signed-off-by: Hector Fernandez hector@chainguard.dev
Summary
There is an increase in the amount of flags used in our commands. Therefore we should think about binding these flags as environment variables that would help us when using the commands.
closes #2330
Release Note
Allow setting flag values via environment variables
Documentation