Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: remove --force flag from sign and attest and rely on --yes flag to skip confirmation #2399

Merged
merged 7 commits into from
Nov 3, 2022

Conversation

priyawadhwa
Copy link
Contributor

Note, this doesn't remove the --force flag from cosign clean and cosign copy, which use it to override destruction of images/signatures.

Release Note

Breaking change: remove --force flag from sign and attest and rely on --yes flag to skip confirmation

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #2399 (5f318be) into main (361110c) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
- Coverage   30.10%   29.52%   -0.58%     
==========================================
  Files         136      136              
  Lines        8451     8444       -7     
==========================================
- Hits         2544     2493      -51     
- Misses       5578     5641      +63     
+ Partials      329      310      -19     
Impacted Files Coverage Δ
cmd/cosign/cli/attest.go 0.00% <ø> (ø)
cmd/cosign/cli/options/attest.go 0.00% <ø> (ø)
cmd/cosign/cli/options/sign.go 0.00% <ø> (ø)
cmd/cosign/cli/sign/sign.go 15.84% <0.00%> (ø)
pkg/oci/layout/signatures.go 0.00% <0.00%> (-53.85%) ⬇️
pkg/oci/layout/write.go 0.00% <0.00%> (-37.50%) ⬇️
pkg/oci/layout/index.go 0.00% <0.00%> (-28.58%) ⬇️
pkg/blob/load.go 67.50% <0.00%> (-5.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@priyawadhwa priyawadhwa merged commit 03ac564 into sigstore:main Nov 3, 2022
@priyawadhwa priyawadhwa deleted the remove-force branch November 3, 2022 18:49
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 3, 2022
hiyosi pushed a commit to zlabjp/slsa-github-generator that referenced this pull request Mar 7, 2023
* `--force` flag is removed by sigstore/cosign#2399
* Use `--yes` instead of `--force`
hiyosi pushed a commit to zlabjp/slsa-github-generator that referenced this pull request Mar 7, 2023
* `--force` flag is removed by sigstore/cosign#2399
* Use `--yes` instead of `--force`

Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
ianlewis pushed a commit to slsa-framework/slsa-github-generator that referenced this pull request Mar 7, 2023
* `--force` flag is removed by sigstore/cosign#2399
* Use `--yes` instead of `--force`

Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants