-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change: remove --force flag from sign and attest and rely on --yes flag to skip confirmation #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #2399 +/- ##
==========================================
- Coverage 30.10% 29.52% -0.58%
==========================================
Files 136 136
Lines 8451 8444 -7
==========================================
- Hits 2544 2493 -51
- Misses 5578 5641 +63
+ Partials 329 310 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
cpanato
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
znewman01
approved these changes
Nov 3, 2022
hiyosi
pushed a commit
to zlabjp/slsa-github-generator
that referenced
this pull request
Mar 7, 2023
* `--force` flag is removed by sigstore/cosign#2399 * Use `--yes` instead of `--force`
hiyosi
pushed a commit
to zlabjp/slsa-github-generator
that referenced
this pull request
Mar 7, 2023
* `--force` flag is removed by sigstore/cosign#2399 * Use `--yes` instead of `--force` Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
ianlewis
pushed a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Mar 7, 2023
* `--force` flag is removed by sigstore/cosign#2399 * Use `--yes` instead of `--force` Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this doesn't remove the --force flag from
cosign clean
andcosign copy
, which use it to override destruction of images/signatures.Release Note
Breaking change: remove --force flag from sign and attest and rely on --yes flag to skip confirmation